Skip to content

Mineways v5.09 Support #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JMY1000 opened this issue Oct 9, 2016 · 9 comments
Open

Mineways v5.09 Support #18

JMY1000 opened this issue Oct 9, 2016 · 9 comments

Comments

@JMY1000
Copy link
Owner

JMY1000 commented Oct 9, 2016

Mineways v5.04 made a lot of changes to how blocks are handled. Due to the way that CyclesMineways looks for strings to identify the proper shader, a lot of shaders got broken.

@erich666
Copy link
Collaborator

erich666 commented Oct 9, 2016

For anyone else reading this issue: This is only if you turn on the "Split materials into subtypes" option (right?). CyclesMineways should work fine for the default "by type, not subtype" materials.

@JMY1000
Copy link
Owner Author

JMY1000 commented Oct 9, 2016

Splitting into subtypes is something we very much do want to support though, as it allows for more "accurate" shading.

@erich666
Copy link
Collaborator

erich666 commented Oct 9, 2016

Right! I just wanted to let any others viewing this issue that it's not Version 5.04 of Mineways that breaks things (which might warn people away from updating), it's only the new export option that's incompatible.

By the way, I tried to make it so that the subtype materials are easily identifiable: they all have the suffix "#" where the number is 1 to whatever, a data value. If there's some way in your script to search for "" and strip it and the rest off, Cycles could then handle any of the new materials by simply ignoring them for now, treating them as the "normal" version. For example, if you see "Stone__1", you treat it as "Stone". You could then, as you and others find time, add in the specific materials you want to make nicer, e.g. Stone__1, Stone__2, etc.

I say all this unconstrained by actual knowledge, so ignore it if it makes no sense.

@ThomasLynn
Copy link
Collaborator

As it stands at the moment with the way we have coded it, blocks are either: a normal; solid block (default); a transparent block, a solid light block; or a transparent, light block.

As is stands, there is no way for us to, for example, make polished granite more shiny using this method. So currently the new feature isn't much use, but it opens some opportunities for us.

For this change to be useful, we need to implement a better way of storing block data (JMY1000 and myself have been talking about this from the beginning) which allows customisation for this sort of stuff (we should probably skype again at some point for this)

@JMY1000 JMY1000 changed the title Mineways v5.04 Support Mineways v5.09 Support Jun 9, 2017
@JMY1000
Copy link
Owner Author

JMY1000 commented Jun 9, 2017

5.09 includes support for Minecraft 1.11 and 1.12

Minecraft 1.11 support will require:

  • New blocks
    • Observers
    • Shulker boxes

Minecraft 1.12 support will require:

  • New blocks
    • Concrete/concrete powder
    • Glazed terracota

@erich666
Copy link
Collaborator

erich666 commented Jun 9, 2017

Thanks! I guess I should be warning you when I add new blocks. As it is, I'm certainly done for awhile.

@JMY1000
Copy link
Owner Author

JMY1000 commented Jun 10, 2017

All the new blocks seem to be supported, since they have no special shaders.

@JMY1000
Copy link
Owner Author

JMY1000 commented Jun 10, 2017

Lily pad shader doesn't seem to be working right, line 274 throws IndexError: tuple index out of range as output.inputs[0].links[0] is empty. Looks like water_shader(material, use_refraction, surface_blue, volume_blue, displacement_type, displacement_amount): forgets to set up the links. @ThomasLynn For now the lily pad shader will no longer link to the "general" water shader.

@JMY1000
Copy link
Owner Author

JMY1000 commented Jun 10, 2017

Support seems to be updated, unless someone has issues with the changes I'll close this issue and merge into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants