Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gulp build: when gulp-jscs fails, its error message is unreadable in Windows command prompt #4

Closed
UltCombo opened this issue Dec 22, 2014 · 10 comments

Comments

@UltCombo
Copy link
Member

The issue seems to be specific to Windows.

Steps to reproduce:

  1. Use the (currently experimental) gulpfile branch
  2. Create a new project
  3. Edit a .js file in order for jscs to fail
  4. Run gulp build

gulp-jscs's error message in Windows 7's cmd.exe only has line breaks visible:
image

However, actually, it looks like the issue is with gulp-jscs's coloring -- if one copies/inspects the actual stdout contents, the correct error message is there.

The same bug also appears in Git Bash:

image

The error message is at least visible in Console2 (albeit the coloring is not applied):

image

Noting again: the issue is apparently specific to Windows; The error message is correctly colored in OS X 10.10's zsh.

@UltCombo
Copy link
Member Author

Well, coloring is not that important, so I guess we can workaround this issue by disabling gulp-jscs coloring in Windows for the time being, until gulp-jscs supports proper reporters.

@jaydson
Copy link

jaydson commented Dec 23, 2014

I'm late.
So, the issue was fixed?

@UltCombo
Copy link
Member Author

Yep. ;) I'm updating some details and writing docs for the gulp version, soon I'll push a slush-es6 alpha release. Will make a couple more tests to make sure everything is alright.

@jaydson
Copy link

jaydson commented Dec 23, 2014

👍

@UltCombo
Copy link
Member Author

Pushed an alpha release! You can try it with:

npm i -g slush-es6@alpha

Let's push a stable release after applying this workflow in Harmonic and giving it some road test.

@btormey
Copy link

btormey commented Aug 6, 2015

Noticing this issue again on Windows 10
capture

@UltCombo
Copy link
Member Author

UltCombo commented Aug 6, 2015

@btormey are you using the version 2.0.3? I'm pretty sure it was fixed in this version.

The next version will be a major release that replaces JSHint and JSCS with ESLint, though I'm currently pondering whether to add JSCS back now that it is able to lint all valid Babel code. By that point we should also have the ability to disable plugins via build.js, so you can use just what you want.

@btormey
Copy link

btormey commented Aug 6, 2015

@UltCombo Ah, that is the issue, I've got 2.0.0 installed. Sorry, it's late here.

@UltCombo
Copy link
Member Author

UltCombo commented Aug 6, 2015

No problem, glad to help. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants