Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately we can't quite finish getting ODEs in Julia, but this should guide the way when we're ready.
The reason we can't finish is because the ODE library uses structs, and the Julia renderer doesn't support structs yet.
Other changes:
[]
; now it isType[]
- e.g. an empty list of doubles isFloat64[]
. The reason for this is because Julia assigns[]
the typeArray{Any}
, which causes problems when you need it to be typeArray{Float}
, for example. I will also create a separate PR for this.populateSolList'
function, which acts like thepopulateSolList
but without accessing a field. I think that once we have structs in Julia, we won't need this function.[]
case fromapplyWithNamedArgs
, as it was causing problems.I commented most of the things that need to be changed once we have structs. You can also refer to my test case here to compare.
@JacquesCarette @smiths @balacij feel free to give any feedback or ask any questions you have.
Contributes to #3918