Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes made
Sanitize filename before saving a generated test.
Why is merge request needed
The filename is created with the class name of the generated test. Even if i's not a good convention, a class name can contain forbidden characters on Windows like
"
if the name is written like this:Other notes
Closes #442
As far as I see, the only place we construct the full path for a generated test is inside the method
saveGeneratedTest
and then the program uses the return value of this function as a path for a test. So, it is safe to do the sanitization here. Please correct me if I'm wrong.What is missing?
Please mention if anything is missing for this merge request, e.g you have decided to move something to the next merge request