Make "extract method" work on multi-line function calls #2981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KalininDL
reviewed
Mar 14, 2025
python/python-psi-impl/src/com/jetbrains/python/refactoring/PyRefactoringUtil.java
Outdated
Show resolved
Hide resolved
chbndrhnns
force-pushed
the
fix-PY-53711
branch
from
95c078a to
0fcb619
Compare
|
@KalininDL I also updated the logic to select the whole expression that is going to be extracted in the preview. |
|
@chbndrhnns Thank you very much for the collaboration! Your changes were approved by QA and merged to the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://youtrack.jetbrains.com/issue/PY-53711/Cannot-extract-method-if-arguments-are-on-separate-line