Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retrier: use atomics as flags #518

Merged
merged 3 commits into from
Jun 25, 2024
Merged

retrier: use atomics as flags #518

merged 3 commits into from
Jun 25, 2024

Conversation

ignoramous
Copy link
Contributor

toctou race in checking closed(ch) to actually closing it, which may result in a panic if chan ch is closed twice.

@ignoramous
retrier: use atomics as flags
74febb5 
toctou race in checking closed(ch) to actually closing it,
which may result in a panic if chan ch is closed twice.
@ignoramous
Copy link
Contributor Author

jyyi1
jyyi1 reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The code LGTM, with some minor comments.

@jyyi1 jyyi1 merged commit 5c6d68d into Jigsaw-Code:master Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyyi1 jyyi1 jyyi1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignoramous @jyyi1