fix(manager): use typeof function instead of directly comparison #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
previously approved these changes
Jan 24, 2024
fortuna
reviewed
Jan 24, 2024
|
It is just example on Java. This is recommendation: https://codeql.github.com/codeql-query-help/javascript/js-comparison-between-incompatible-types/ |
daniellacosse
requested changes
Jan 24, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fortuna
requested changes
Jan 24, 2024
src/server_manager/web_app/ui_components/outline-server-settings.ts
Outdated
Show resolved
Hide resolved
fortuna
changed the title
murka
commented
Jan 25, 2024
There was a problem hiding this comment.
All the workflows are passed! The PR is ready for merge, imho :)
https://github.com/murka/outline-server/actions/runs/7652358841
fortuna
approved these changes
Jan 29, 2024
|
@daniellacosse another look? |
src/server_manager/web_app/ui_components/outline-server-settings.ts
Outdated
Show resolved
Hide resolved
|
I'm fine with that!
…On Tue, Jan 30, 2024, 3:54 PM Vinicius Fortuna ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/server_manager/web_app/ui_components/outline-server-settings.ts
<#1481 (comment)>
:
> return;
- } else if (isDataLimitEnabled === wasDataLimitEnabled) {
+ }
+ const isDataLimitEnabled = e.detail.value === 'enabled';
+ if (isDataLimitEnabled === this.isDefaultDataLimitEnabled) {
Perhaps name it enableDataLimit?
if (this.isDefaultDataLimitEnabled === enableDataLimit) {
return;}
—
Reply to this email directly, view it on GitHub
<#1481 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4V5VCMPFV7WWFH5FUGSTDYRFMZFAVCNFSM6AAAAABCJECPSKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNJSGM2DCMBTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
fortuna
reviewed
Jan 31, 2024
src/server_manager/web_app/ui_components/outline-server-settings.ts
Outdated
Show resolved
Hide resolved
…gs.ts Co-authored-by: Vinicius Fortuna <fortuna@users.noreply.github.com>
daniellacosse
approved these changes
Feb 1, 2024
|
@murka it seems like the test failed. Can you take a look? |
|
@fortuna, I fix that. All jobs is done: https://github.com/murka/outline-server/actions/runs/7743696038/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CWE-570 and CWE-571
More info: https://github.com/murka/outline-server/security/code-scanning/3