Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix Uint<256> conversion issues by clamping values #556

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

Jon-Becker
Copy link
Owner

Motivation

Closes #545

Solution

Copy link
Contributor

Benchmark for 5ccbc21

Click to view benchmark
Test Base PR %
heimdall_cfg/complex 13.1±0.06ms 13.0±0.10ms -0.76%
heimdall_cfg/simple 1956.7±9.27µs 2.1±0.01ms +7.32%
heimdall_decoder/seaport 31.1±0.80µs 31.7±0.78µs +1.93%
heimdall_decoder/transfer 3.6±0.20µs 3.5±0.25µs -2.78%
heimdall_decoder/uniswap 10.4±0.52µs 10.5±0.41µs +0.96%
heimdall_decompiler/abi_complex 50.7±0.29ms 58.2±1.03ms +14.79%
heimdall_decompiler/abi_simple 2.1±0.01ms 2.0±0.02ms -4.76%
heimdall_decompiler/sol_complex 62.1±0.50ms 67.9±4.27ms +9.34%
heimdall_decompiler/sol_simple 2.6±0.01ms 2.5±0.08ms -3.85%
heimdall_decompiler/yul_complex 54.2±0.23ms 59.3±4.95ms +9.41%
heimdall_decompiler/yul_simple 2.3±0.02ms 2.2±0.05ms -4.35%
heimdall_disassembler/complex 709.7±13.52µs 775.1±65.21µs +9.22%
heimdall_disassembler/simple 38.7±2.76µs 39.2±2.81µs +1.29%
heimdall_vm/erc20_transfer 270.1±7.12µs 284.1±28.55µs +5.18%
heimdall_vm/fib 741.6±7.91µs 699.5±24.00µs -5.68%
heimdall_vm/ten_thousand_hashes 513.3±9.67ms 515.1±9.48ms +0.35%

@Jon-Becker Jon-Becker merged commit bd3a00b into main Jan 30, 2025
8 checks passed
Copy link
Contributor

Benchmark for 0b827c4

Click to view benchmark
Test Base PR %
heimdall_cfg/complex 15.2±1.66ms 13.5±0.89ms -11.18%
heimdall_cfg/simple 2.1±0.16ms 2.0±0.03ms -4.76%
heimdall_decoder/seaport 35.3±3.38µs 34.6±4.06µs -1.98%
heimdall_decoder/transfer 3.6±0.30µs 3.6±0.36µs 0.00%
heimdall_decoder/uniswap 11.5±1.51µs 10.2±0.23µs -11.30%
heimdall_decompiler/abi_complex 52.0±1.30ms 53.2±3.07ms +2.31%
heimdall_decompiler/abi_simple 2.0±0.04ms 1943.3±14.32µs -2.83%
heimdall_decompiler/sol_complex 67.3±4.61ms 65.3±0.78ms -2.97%
heimdall_decompiler/sol_simple 2.7±0.11ms 2.4±0.01ms -11.11%
heimdall_decompiler/yul_complex 60.0±4.12ms 54.1±1.36ms -9.83%
heimdall_decompiler/yul_simple 2.3±0.09ms 2.2±0.04ms -4.35%
heimdall_disassembler/complex 771.6±42.63µs 776.5±104.76µs +0.64%
heimdall_disassembler/simple 39.5±1.87µs 38.4±2.27µs -2.78%
heimdall_vm/erc20_transfer 299.1±17.31µs 303.2±23.03µs +1.37%
heimdall_vm/fib 715.9±6.56µs 710.9±4.73µs -0.70%
heimdall_vm/ten_thousand_hashes 558.2±41.34ms 509.1±9.57ms -8.80%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] uint256 "value is too large for usize" error
1 participant