fix(disassemble): PC should start from 0 instead of 1

[chen4903]

Motivation

The same problem as #559, but now it has turned to disassemble. We should also start from zero, not one.
Here is a test:

#[cfg(test)]
mod tests {
    use super::super::DisassemblerArgsBuilder;
    use super::disassemble;
    use tokio::test;

    #[test]
    async fn test_disassemble() -> Result<(), Box<dyn std::error::Error>> {
        let args = DisassemblerArgsBuilder::new()
            .target("0x9f00c43700bc0000Ff91bE00841F8e04c0495000".to_string())
            .rpc_url("https://eth.llamarpc.com".to_string())
            .build()
            .unwrap();

        let result = disassemble(args).await.unwrap();

        println!("Disassembled contract: {:#?}", result);

        Ok(())
    }
}

Old result:

Disassembled contract: "000001 PUSH1 80\n000003 PUSH1 40\n000004 MSTORE \n000005 CALLVALUE \n000006 DUP1...

After update the offset:

Disassembled contract: "000000 PUSH1 80\n000002 PUSH1 40\n000003 MSTORE \n000004 CALLVALUE \n000005 DUP1...

Solution

Simply subtract 1 from the offset:

let offset = program_counter - 1;
        asm.push_str(
            format!(
                "{} {} {}\n",
                if args.decimal_counter {
                    offset.to_string()
                } else {
                    format!("{:06x}", offset)
                },
                opcode_name(opcode),
                pushed_bytes
            )
            .as_str(),
        );

[chen4903]

hi @Jon-Becker . Thanks for merging if there are no more problems. (Not sure why the test fails)

[Jon-Becker]

hey! can you just run cargo fmt and recommit?

[chen4903]

hey! can you just run cargo fmt and recommit?

done

[Jon-Becker]

It seems like some of the disassemble tests expect 0, and some expect 1. I will investigate and fix / review tonight :)