Skip to content

Better handling of bundled modules to get default configs #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

dathbe
Copy link
Contributor

@dathbe dathbe commented Apr 16, 2025

See #331

@KristjanESPERANTO
Copy link
Collaborator

Thanks for the PR! 😃 Please run npm run lint:fix to fix the linter issues.

@dathbe
Copy link
Contributor Author

dathbe commented Apr 22, 2025

Done

@dathbe
Copy link
Contributor Author

dathbe commented Apr 22, 2025

Did I do something to bork my system, or is there something wrong with, perhaps, one of the dependencies here? As of yesterday evening, I am getting the following error message when loading Remote-Control (both my patch-1 branch and the master branch here), and when I try to reinstall the process takes forever and hangs. Other modules seem to install fine.

0|mm  | [2025-04-22 08:58:58.566] [ERROR] MODULE LIST ERROR: Could not check last modified time. [Error: ENOENT: no such file or directory, stat '/home/mmuser/MagicMirror/modules/MMM-Remote-Control/modules.json'] {
0|mm  |   errno: -2,
0|mm  |   code: 'ENOENT',
0|mm  |   syscall: 'stat',
0|mm  |   path: '/home/mmuser/MagicMirror/modules/MMM-Remote-Control/modules.json'
0|mm  | } 
0|mm  | [2025-04-22 08:58:58.571] [ERROR] [MMM-Remote-Control] ERROR_CHECKING_LAST_MODIFIED 
0|mm  | [2025-04-22 08:58:59.934] [LOG]   Launching application. 
0|mm  | [2025-04-22 08:59:03.326] [ERROR] Whoops! There was an uncaught exception... 
0|mm  | [2025-04-22 08:59:03.332] [ERROR] TypeError: Cannot read properties of undefined (reading 'toString')
0|mm  |     at ReadFileContext.callback (/home/mmuser/MagicMirror/modules/MMM-Remote-Control/node_helper.js:205:47)
0|mm  |     at FSReqCallback.readFileAfterOpen [as oncomplete] (node:fs:299:13) 
0|mm  | [2025-04-22 08:59:03.334] [ERROR] MagicMirror² will not quit, but it might be a good idea to check why this happened. Maybe no internet connection? 
0|mm  | [2025-04-22 08:59:03.336] [ERROR] If you think this really is an issue, please open an issue on GitHub: https://github.com/MagicMirrorOrg/MagicMirror/issues 

UPDATE 4/23: Installing dependencies still takes an excessively long time (~17 minutes), but if the process completes successfully, I think this error does not manifest.

UPDATE 4/24: It's swagger-ui, which by itself takes 16 minutes to install.

@KristjanESPERANTO KristjanESPERANTO changed the base branch from master to develop April 23, 2025 18:09
@dathbe dathbe changed the title Add check for "(Log)" at end of module config file Better handling of bundled modules to get default configs Apr 24, 2025
@KristjanESPERANTO
Copy link
Collaborator

As release 3.1.8 has solved the problem in another way, I am closing the PR. Thanks for your helpful input! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants