[Lens] Fix filter labels (elastic#211998)

Fixes issue causing filter labels to render as `undefined`. Filter labels now display correctly.
JoseLuisGJ · Feb 27, 2025 · f45edf6 · f45edf6
1 parent 9e2a5c4
commit f45edf6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/...tform/plugins/shared/unified_search/public/filter_badge/filter_content/filter_content.tsx b/...tform/plugins/shared/unified_search/public/filter_badge/filter_content/filter_content.tsx
@@ -51,11 +51,11 @@ export interface FilterContentProps {
 }
 
 export function FilterContent({ filter, valueLabel, fieldLabel, hideAlias }: FilterContentProps) {
-  if (!hideAlias && filter.meta.alias !== null) {
+  if (!hideAlias && filter.meta.alias != null) {
     return (
       <>
         <Prefix prefix={filter.meta.negate} />
-        <FilterValue value={`${filter.meta.alias}`} />
+        <FilterValue value={filter.meta.alias} />
       </>
     );
   }

diff --git a/x-pack/test/functional/apps/lens/group4/dashboard.ts b/x-pack/test/functional/apps/lens/group4/dashboard.ts
@@ -75,6 +75,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
       await dashboardAddPanel.closeAddPanel();
       await retry.try(async () => {
         await clickInChart(30, 5); // hardcoded position of bar, depends heavy on data and charts implementation
+        const filters = await find.allByCssSelector('.euiCheckbox');
+        expect(filters).length(2);
+        const [timeFilter, ipFilter] = filters;
+        expect(await timeFilter.getVisibleText()).to.be(
+          '@timestamp: Sep 21, 2015 @ 09:00:00.000 to Sep 21, 2015 @ 12:00:00.000'
+        );
+        expect(await ipFilter.getVisibleText()).to.be('ip: 97.220.3.248');
+
         await testSubjects.existOrFail('applyFiltersPopoverButton', { timeout: 2500 });
       });