Skip to content

Add support for faraday 2.x #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 2, 2024
Merged

Add support for faraday 2.x #412

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
78c1f6e
Remove depredated faraday_middleware
tapajos Aug 5, 2022
d68c85c
Move appraisal to a development dependency
lavoiesl Nov 25, 2023
4ba3cd1
Prefix activesupport appraisals
lavoiesl Nov 25, 2023
5a31941
Change activesupport appraisals to >= 6.0
lavoiesl May 2, 2024
977015f
Allow Faraday 2.x
lavoiesl Nov 25, 2023
b4c08b1
Add support for Faraday 2.x
lavoiesl Nov 25, 2023
6e09178
Drop unsupported Ruby versions
lavoiesl May 2, 2024
1db00ea
Update the changelog
lavoiesl May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 8 additions & 22 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,27 +22,11 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: [2.3, 2.4, 2.5, 2.6, 2.7]
rails: ["4.1", "4.2", "5.0", "5.2.3", "6.0"]
exclude:
- ruby: "2.4"
rails: "4.1"
- ruby: "2.4"
rails: "4.2"
- ruby: "2.4"
rails: "6.0"
- ruby: "2.5"
rails: "4.1"
- ruby: "2.5"
rails: "4.2"
- ruby: "2.6"
rails: "4.1"
- ruby: "2.6"
rails: "4.2"
- ruby: "2.7"
rails: "4.1"
- ruby: "2.7"
rails: "4.2"
ruby:
- "3.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be quoted, otherwise 3.0 becomes 3, which gets interpreted as 3.x, resolving to 3.3

- "3.1"
- "3.2"
- "3.3"
steps:
- uses: actions/checkout@v4
- name: Set up Ruby
Expand All @@ -51,4 +35,6 @@ jobs:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true # runs 'bundle install' and caches installed gems automatically
- name: Run tests
run: bundle exec rake
run: |
bundle exec appraisal install
bundle exec appraisal rake test