#34 renamed from SlackAPI to SlackAPIClient

JujaLabs · Jan 8, 2018 · 6c1611a · 6c1611a
1 parent cb84d46
commit 6c1611a
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 12 deletions.
diff --git a/slack-archive/src/main/java/juja/microservices/slack/archive/Application.java b/slack-archive/src/main/java/juja/microservices/slack/archive/Application.java
@@ -16,7 +16,6 @@
 import java.util.List;
 
 @SpringBootApplication
-@EnableScheduling
 public class Application {
 
     public static void main(String[] args) {

diff --git a/slack-archive/src/main/java/juja/microservices/slack/archive/SchedulerConfig.java b/slack-archive/src/main/java/juja/microservices/slack/archive/SchedulerConfig.java
@@ -1,11 +1,13 @@
 package juja.microservices.slack.archive;
 
 import org.springframework.context.annotation.Configuration;
+import org.springframework.scheduling.annotation.EnableScheduling;
 import org.springframework.scheduling.annotation.SchedulingConfigurer;
 import org.springframework.scheduling.concurrent.ThreadPoolTaskScheduler;
 import org.springframework.scheduling.config.ScheduledTaskRegistrar;
 
 @Configuration
+@EnableScheduling
 public class SchedulerConfig implements SchedulingConfigurer {
 
     private final int POOL_SIZE = 2;

diff --git a/...oservices/slack/archive/api/SlackApi.java → ...ces/slack/archive/api/SlackApiClient.java b/...oservices/slack/archive/api/SlackApi.java → ...ces/slack/archive/api/SlackApiClient.java
@@ -4,7 +4,7 @@
 
 import java.util.List;
 
-public interface SlackApi {
+public interface SlackApiClient {
 
     List<ChannelDTO> receiveChannelsList();
 }
diff --git a/...vices/slack/archive/api/SlackApiImpl.java → ...slack/archive/api/SlackApiClientImpl.java b/...vices/slack/archive/api/SlackApiImpl.java → ...slack/archive/api/SlackApiClientImpl.java
@@ -14,7 +14,7 @@
 
 @Repository
 @Slf4j
-public class SlackApiImpl implements SlackApi {
+public class SlackApiClientImpl implements SlackApiClient {
 
     private final RestTemplate restTemplate;
 
@@ -23,7 +23,7 @@ public class SlackApiImpl implements SlackApi {
     @Value("${slack.api.channels.urltemplate}")
     private String slackApiChannelsUrlTemplate;
 
-    public SlackApiImpl(RestTemplate restTemplate) {
+    public SlackApiClientImpl(RestTemplate restTemplate) {
         this.restTemplate = restTemplate;
     }
 

diff --git a/...hive/src/main/java/juja/microservices/slack/archive/service/impl/SlackApiServiceImpl.java b/...hive/src/main/java/juja/microservices/slack/archive/service/impl/SlackApiServiceImpl.java
@@ -1,7 +1,7 @@
 package juja.microservices.slack.archive.service.impl;
 
 import juja.microservices.slack.archive.model.dto.ChannelDTO;
-import juja.microservices.slack.archive.api.SlackApi;
+import juja.microservices.slack.archive.api.SlackApiClient;
 import juja.microservices.slack.archive.service.SlackApiService;
 import org.springframework.stereotype.Service;
 
@@ -10,14 +10,14 @@
 @Service
 public class SlackApiServiceImpl implements SlackApiService {
 
-    private SlackApi slackApi;
+    private SlackApiClient slackApiClient;
 
-    public SlackApiServiceImpl(SlackApi slackApi) {
-        this.slackApi = slackApi;
+    public SlackApiServiceImpl(SlackApiClient slackApiClient) {
+        this.slackApiClient = slackApiClient;
     }
 
     @Override
     public List<ChannelDTO> receiveChannels() {
-        return slackApi.receiveChannelsList();
+        return slackApiClient.receiveChannelsList();
     }
 }
diff --git a/...s/slack/archive/api/SlackApiImplTest.java → ...k/archive/api/SlackApiClientImplTest.java b/...s/slack/archive/api/SlackApiImplTest.java → ...k/archive/api/SlackApiClientImplTest.java
@@ -24,12 +24,12 @@
 
 @RunWith(SpringRunner.class)
 @SpringBootTest
-public class SlackApiImplTest {
+public class SlackApiClientImplTest {
 
     @Inject
     private RestTemplate restTemplate;
     @Inject
-    private SlackApi slackApi;
+    private SlackApiClient slackApiClient;
     private MockRestServiceServer mockServer;
     @Value("${slack.api.token}")
     private String slackApiToken;
@@ -54,7 +54,7 @@ public void receiveChannelsList() throws Exception {
                .andExpect(method(HttpMethod.GET))
                .andRespond(withSuccess(Util.readStringFromFile("api/channels.json"), MediaType.APPLICATION_JSON));
 
-        List<ChannelDTO> result = slackApi.receiveChannelsList();
+        List<ChannelDTO> result = slackApiClient.receiveChannelsList();
 
         assertEquals(expectedChannels, result);
     }