Create an interface for column components other than MultiDocRef #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![semgrep-code-juliacomputing-new[bot]](https://avatars.githubusercontent.com/u/10258468?s=60&v=4){kind=small}
Co-authored-by: semgrep-code-juliacomputing-new[bot] <177960334+semgrep-code-juliacomputing-new[bot]@users.noreply.github.com>
|
Looks like Windows tests are failing because of an extra carriage return ( |
pfitzseb
reviewed
Feb 21, 2025
pfitzseb
reviewed
Feb 24, 2025
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
|
We can make Link look pretty in a separate PR - this is ready from my end now! |
pfitzseb
reviewed
Feb 26, 2025
Co-authored-by: Sebastian Pfitzner <pfitzseb@gmail.com>
pfitzseb
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to add some custom components (external links SciML/SciMLDocs#240, commercial support icons, etc.) but the current structure of MultiDocumenter constrains this to MultiDocRef.
This PR introduces an abstract supertype of MultiDocRef,
DropdownComponent(name up for review) where the only interface requirement is that the subtype implementsrender(::Component, doc, page, prettyurls). This can be used to create arbitrary components that are rendered as arbitrary HTML, within the column environment.