-
Notifications
You must be signed in to change notification settings - Fork 7
Create an interface for column components other than MultiDocRef #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5b1072a
Create an interface for column components other than MultiDocRef
asinghvi17 7acd3ae
Fix whitespace issues suggested by Semgrep
asinghvi17 4aeb4be
Don't restrict types
asinghvi17 4d4fab3
add a Link component to emphasize the renderer interface
asinghvi17 b22d26b
Use that link in docs and tests
asinghvi17 a02cb96
code style changes
asinghvi17 eb4edc2
`flatten_multidocrefs` -> `flatten_dropdowncomponents`
asinghvi17 3a47640
Finish refactoring Link
asinghvi17 0612758
better MultiDocRef docs
asinghvi17 5ddcfc9
Update src/renderers.jl
asinghvi17 c2b0f07
add an `isexternal` field to Link
asinghvi17 2c34b80
implement the automated check we discussed
asinghvi17 e8e8f8e
Run formatter
asinghvi17 cfdeff5
use the external field of link to determine new tab or same tab
asinghvi17 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.