Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that malformed allocations throw and don't stackoverflow (#576) #577

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

vchuravy
Copy link
Member

(cherry picked from commit ccb0211)

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (087d9fa) to head (054fcd1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/KernelAbstractions.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #577   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         21      21           
  Lines       1575    1575           
=====================================
  Misses      1575    1575           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Benchmark Results

main 054fcd1... main/054fcd15e2feb5...
saxpy/default/Float16/1024 0.0553 ± 0.025 ms 0.043 ± 0.025 ms 1.29
saxpy/default/Float16/1048576 0.894 ± 0.024 ms 0.889 ± 0.025 ms 1.01
saxpy/default/Float16/16384 0.0647 ± 0.028 ms 0.0595 ± 0.026 ms 1.09
saxpy/default/Float16/2048 0.0578 ± 0.023 ms 0.0474 ± 0.022 ms 1.22
saxpy/default/Float16/256 0.0624 ± 0.026 ms 0.0416 ± 0.026 ms 1.5
saxpy/default/Float16/262144 0.273 ± 0.025 ms 0.266 ± 0.025 ms 1.03
saxpy/default/Float16/32768 0.0792 ± 0.028 ms 0.0725 ± 0.025 ms 1.09
saxpy/default/Float16/4096 0.0669 ± 0.026 ms 0.058 ± 0.026 ms 1.15
saxpy/default/Float16/512 0.0572 ± 0.025 ms 0.0435 ± 0.026 ms 1.31
saxpy/default/Float16/64 0.0623 ± 0.026 ms 0.0421 ± 0.028 ms 1.48
saxpy/default/Float16/65536 0.112 ± 0.027 ms 0.1 ± 0.026 ms 1.12
saxpy/default/Float32/1024 0.0564 ± 0.026 ms 0.0438 ± 0.026 ms 1.29
saxpy/default/Float32/1048576 0.477 ± 0.033 ms 0.469 ± 0.054 ms 1.02
saxpy/default/Float32/16384 0.0564 ± 0.026 ms 0.0533 ± 0.023 ms 1.06
saxpy/default/Float32/2048 0.0537 ± 0.023 ms 0.0449 ± 0.022 ms 1.2
saxpy/default/Float32/256 0.0594 ± 0.026 ms 0.0413 ± 0.027 ms 1.44
saxpy/default/Float32/262144 0.167 ± 0.035 ms 0.153 ± 0.034 ms 1.09
saxpy/default/Float32/32768 0.0616 ± 0.026 ms 0.059 ± 0.025 ms 1.04
saxpy/default/Float32/4096 0.0601 ± 0.025 ms 0.0495 ± 0.025 ms 1.21
saxpy/default/Float32/512 0.0584 ± 0.026 ms 0.0422 ± 0.027 ms 1.38
saxpy/default/Float32/64 0.0623 ± 0.027 ms 0.0423 ± 0.027 ms 1.47
saxpy/default/Float32/65536 0.0808 ± 0.028 ms 0.0724 ± 0.028 ms 1.12
saxpy/default/Float64/1024 0.0556 ± 0.026 ms 0.0438 ± 0.026 ms 1.27
saxpy/default/Float64/1048576 0.508 ± 0.046 ms 0.505 ± 0.048 ms 1.01
saxpy/default/Float64/16384 0.0577 ± 0.026 ms 0.0541 ± 0.024 ms 1.07
saxpy/default/Float64/2048 0.0492 ± 0.023 ms 0.0442 ± 0.021 ms 1.11
saxpy/default/Float64/256 0.0572 ± 0.026 ms 0.0427 ± 0.027 ms 1.34
saxpy/default/Float64/262144 0.175 ± 0.029 ms 0.168 ± 0.031 ms 1.04
saxpy/default/Float64/32768 0.0643 ± 0.026 ms 0.0624 ± 0.024 ms 1.03
saxpy/default/Float64/4096 0.0603 ± 0.025 ms 0.0491 ± 0.024 ms 1.23
saxpy/default/Float64/512 0.0583 ± 0.026 ms 0.0421 ± 0.027 ms 1.38
saxpy/default/Float64/64 0.0587 ± 0.026 ms 0.0416 ± 0.028 ms 1.41
saxpy/default/Float64/65536 0.0908 ± 0.027 ms 0.0811 ± 0.025 ms 1.12
saxpy/static workgroup=(1024,)/Float16/1024 0.0444 ± 0.025 ms 0.0426 ± 0.025 ms 1.04
saxpy/static workgroup=(1024,)/Float16/1048576 0.902 ± 0.025 ms 0.898 ± 0.03 ms 1
saxpy/static workgroup=(1024,)/Float16/16384 0.0608 ± 0.026 ms 0.0575 ± 0.024 ms 1.06
saxpy/static workgroup=(1024,)/Float16/2048 0.0556 ± 0.024 ms 0.0481 ± 0.023 ms 1.16
saxpy/static workgroup=(1024,)/Float16/256 0.0536 ± 0.026 ms 0.0433 ± 0.026 ms 1.24
saxpy/static workgroup=(1024,)/Float16/262144 0.271 ± 0.027 ms 0.265 ± 0.027 ms 1.02
saxpy/static workgroup=(1024,)/Float16/32768 0.0769 ± 0.026 ms 0.0706 ± 0.023 ms 1.09
saxpy/static workgroup=(1024,)/Float16/4096 0.0603 ± 0.026 ms 0.0484 ± 0.026 ms 1.24
saxpy/static workgroup=(1024,)/Float16/512 0.0546 ± 0.025 ms 0.0435 ± 0.025 ms 1.25
saxpy/static workgroup=(1024,)/Float16/64 0.0512 ± 0.026 ms 0.0444 ± 0.026 ms 1.15
saxpy/static workgroup=(1024,)/Float16/65536 0.108 ± 0.026 ms 0.0979 ± 0.024 ms 1.11
saxpy/static workgroup=(1024,)/Float32/1024 0.0554 ± 0.026 ms 0.0446 ± 0.026 ms 1.24
saxpy/static workgroup=(1024,)/Float32/1048576 0.471 ± 0.038 ms 0.455 ± 0.053 ms 1.04
saxpy/static workgroup=(1024,)/Float32/16384 0.0536 ± 0.025 ms 0.0514 ± 0.023 ms 1.04
saxpy/static workgroup=(1024,)/Float32/2048 0.0502 ± 0.023 ms 0.0442 ± 0.023 ms 1.13
saxpy/static workgroup=(1024,)/Float32/256 0.0602 ± 0.025 ms 0.0437 ± 0.026 ms 1.38
saxpy/static workgroup=(1024,)/Float32/262144 0.161 ± 0.034 ms 0.149 ± 0.034 ms 1.08
saxpy/static workgroup=(1024,)/Float32/32768 0.0592 ± 0.026 ms 0.0566 ± 0.024 ms 1.05
saxpy/static workgroup=(1024,)/Float32/4096 0.0548 ± 0.026 ms 0.047 ± 0.026 ms 1.17
saxpy/static workgroup=(1024,)/Float32/512 0.0579 ± 0.025 ms 0.0418 ± 0.026 ms 1.39
saxpy/static workgroup=(1024,)/Float32/64 0.059 ± 0.025 ms 0.043 ± 0.025 ms 1.37
saxpy/static workgroup=(1024,)/Float32/65536 0.0766 ± 0.028 ms 0.0701 ± 0.027 ms 1.09
saxpy/static workgroup=(1024,)/Float64/1024 0.0526 ± 0.025 ms 0.0415 ± 0.026 ms 1.27
saxpy/static workgroup=(1024,)/Float64/1048576 0.508 ± 0.04 ms 0.5 ± 0.052 ms 1.01
saxpy/static workgroup=(1024,)/Float64/16384 0.0554 ± 0.026 ms 0.0524 ± 0.024 ms 1.06
saxpy/static workgroup=(1024,)/Float64/2048 0.0469 ± 0.023 ms 0.0442 ± 0.022 ms 1.06
saxpy/static workgroup=(1024,)/Float64/256 0.0574 ± 0.025 ms 0.0422 ± 0.026 ms 1.36
saxpy/static workgroup=(1024,)/Float64/262144 0.173 ± 0.029 ms 0.166 ± 0.032 ms 1.04
saxpy/static workgroup=(1024,)/Float64/32768 0.0627 ± 0.025 ms 0.0602 ± 0.024 ms 1.04
saxpy/static workgroup=(1024,)/Float64/4096 0.0565 ± 0.026 ms 0.0463 ± 0.026 ms 1.22
saxpy/static workgroup=(1024,)/Float64/512 0.0536 ± 0.026 ms 0.0427 ± 0.026 ms 1.25
saxpy/static workgroup=(1024,)/Float64/64 0.0519 ± 0.026 ms 0.0425 ± 0.025 ms 1.22
saxpy/static workgroup=(1024,)/Float64/65536 0.0891 ± 0.027 ms 0.0784 ± 0.027 ms 1.14
time_to_load 1.12 ± 0.0067 s 1.11 ± 0.011 s 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@vchuravy vchuravy merged commit a1535e5 into main Feb 26, 2025
20 of 27 checks passed
@vchuravy vchuravy deleted the vc/throw_error_on_allocate_0.10 branch February 26, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant