Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SPIR-V to 1.2 #582

Merged
merged 4 commits into from
Mar 12, 2025
Merged

Set SPIR-V to 1.2 #582

merged 4 commits into from
Mar 12, 2025

Conversation

vchuravy
Copy link
Member

  • Set SPIR-V manually to 1.2
  • remove isgpu check

@vchuravy
Copy link
Member Author

@maleadt otherwise on POCL main I am seeing:

InvalidModule: Invalid SPIR-V module: incorrect SPIR-V version number 1.4 (66560) - it conflicts with --spirv-max-version which is set to 1.2 (66048)
ERROR: Package KernelAbstractions errored during testing (exit code: 11)

Copy link
Contributor

github-actions bot commented Mar 12, 2025

Benchmark Results

main 3c3d248... main/3c3d248216d036...
saxpy/default/Float16/1024 0.0595 ± 0.026 ms 0.048 ± 0.026 ms 1.24
saxpy/default/Float16/1048576 0.891 ± 0.025 ms 0.885 ± 0.024 ms 1.01
saxpy/default/Float16/16384 0.0659 ± 0.027 ms 0.0591 ± 0.023 ms 1.11
saxpy/default/Float16/2048 0.0579 ± 0.024 ms 0.0476 ± 0.022 ms 1.22
saxpy/default/Float16/256 0.0602 ± 0.026 ms 0.0489 ± 0.027 ms 1.23
saxpy/default/Float16/262144 0.271 ± 0.025 ms 0.266 ± 0.025 ms 1.02
saxpy/default/Float16/32768 0.0766 ± 0.027 ms 0.0727 ± 0.025 ms 1.05
saxpy/default/Float16/4096 0.0562 ± 0.024 ms 0.0544 ± 0.026 ms 1.03
saxpy/default/Float16/512 0.0558 ± 0.026 ms 0.0451 ± 0.026 ms 1.24
saxpy/default/Float16/64 0.0615 ± 0.027 ms 0.0413 ± 0.027 ms 1.49
saxpy/default/Float16/65536 0.109 ± 0.027 ms 0.1 ± 0.026 ms 1.09
saxpy/default/Float32/1024 0.0622 ± 0.026 ms 0.0444 ± 0.026 ms 1.4
saxpy/default/Float32/1048576 0.48 ± 0.025 ms 0.47 ± 0.055 ms 1.02
saxpy/default/Float32/16384 0.0551 ± 0.025 ms 0.054 ± 0.022 ms 1.02
saxpy/default/Float32/2048 0.0517 ± 0.023 ms 0.0476 ± 0.024 ms 1.09
saxpy/default/Float32/256 0.0609 ± 0.025 ms 0.0466 ± 0.027 ms 1.31
saxpy/default/Float32/262144 0.161 ± 0.035 ms 0.152 ± 0.035 ms 1.06
saxpy/default/Float32/32768 0.0602 ± 0.026 ms 0.0595 ± 0.024 ms 1.01
saxpy/default/Float32/4096 0.0599 ± 0.025 ms 0.0487 ± 0.024 ms 1.23
saxpy/default/Float32/512 0.0562 ± 0.027 ms 0.044 ± 0.027 ms 1.28
saxpy/default/Float32/64 0.0583 ± 0.026 ms 0.0456 ± 0.028 ms 1.28
saxpy/default/Float32/65536 0.0753 ± 0.029 ms 0.0724 ± 0.028 ms 1.04
saxpy/default/Float64/1024 0.048 ± 0.026 ms 0.0434 ± 0.026 ms 1.11
saxpy/default/Float64/1048576 0.505 ± 0.052 ms 0.502 ± 0.052 ms 1.01
saxpy/default/Float64/16384 0.0562 ± 0.026 ms 0.0541 ± 0.024 ms 1.04
saxpy/default/Float64/2048 0.0457 ± 0.023 ms 0.0456 ± 0.022 ms 1
saxpy/default/Float64/256 0.0612 ± 0.027 ms 0.0443 ± 0.027 ms 1.38
saxpy/default/Float64/262144 0.172 ± 0.029 ms 0.167 ± 0.03 ms 1.03
saxpy/default/Float64/32768 0.0641 ± 0.026 ms 0.0616 ± 0.024 ms 1.04
saxpy/default/Float64/4096 0.0561 ± 0.024 ms 0.0497 ± 0.025 ms 1.13
saxpy/default/Float64/512 0.0583 ± 0.027 ms 0.0447 ± 0.027 ms 1.3
saxpy/default/Float64/64 0.0464 ± 0.029 ms 0.0447 ± 0.029 ms 1.04
saxpy/default/Float64/65536 0.0876 ± 0.027 ms 0.0798 ± 0.026 ms 1.1
saxpy/static workgroup=(1024,)/Float16/1024 0.0556 ± 0.026 ms 0.0436 ± 0.025 ms 1.27
saxpy/static workgroup=(1024,)/Float16/1048576 0.897 ± 0.028 ms 0.894 ± 0.029 ms 1
saxpy/static workgroup=(1024,)/Float16/16384 0.0593 ± 0.026 ms 0.0568 ± 0.023 ms 1.04
saxpy/static workgroup=(1024,)/Float16/2048 0.0573 ± 0.023 ms 0.0493 ± 0.023 ms 1.16
saxpy/static workgroup=(1024,)/Float16/256 0.0611 ± 0.026 ms 0.0538 ± 0.026 ms 1.14
saxpy/static workgroup=(1024,)/Float16/262144 0.27 ± 0.027 ms 0.266 ± 0.027 ms 1.01
saxpy/static workgroup=(1024,)/Float16/32768 0.0729 ± 0.025 ms 0.0695 ± 0.023 ms 1.05
saxpy/static workgroup=(1024,)/Float16/4096 0.05 ± 0.026 ms 0.0469 ± 0.026 ms 1.07
saxpy/static workgroup=(1024,)/Float16/512 0.0579 ± 0.026 ms 0.0444 ± 0.026 ms 1.3
saxpy/static workgroup=(1024,)/Float16/64 0.0604 ± 0.026 ms 0.0573 ± 0.026 ms 1.05
saxpy/static workgroup=(1024,)/Float16/65536 0.101 ± 0.026 ms 0.0964 ± 0.024 ms 1.04
saxpy/static workgroup=(1024,)/Float32/1024 0.0546 ± 0.026 ms 0.0417 ± 0.026 ms 1.31
saxpy/static workgroup=(1024,)/Float32/1048576 0.463 ± 0.033 ms 0.453 ± 0.049 ms 1.02
saxpy/static workgroup=(1024,)/Float32/16384 0.0524 ± 0.024 ms 0.0506 ± 0.023 ms 1.04
saxpy/static workgroup=(1024,)/Float32/2048 0.0524 ± 0.023 ms 0.0437 ± 0.021 ms 1.2
saxpy/static workgroup=(1024,)/Float32/256 0.0606 ± 0.026 ms 0.0476 ± 0.026 ms 1.27
saxpy/static workgroup=(1024,)/Float32/262144 0.155 ± 0.034 ms 0.147 ± 0.034 ms 1.05
saxpy/static workgroup=(1024,)/Float32/32768 0.0579 ± 0.026 ms 0.0567 ± 0.024 ms 1.02
saxpy/static workgroup=(1024,)/Float32/4096 0.0507 ± 0.026 ms 0.0462 ± 0.025 ms 1.1
saxpy/static workgroup=(1024,)/Float32/512 0.0581 ± 0.026 ms 0.0453 ± 0.026 ms 1.28
saxpy/static workgroup=(1024,)/Float32/64 0.058 ± 0.025 ms 0.054 ± 0.026 ms 1.07
saxpy/static workgroup=(1024,)/Float32/65536 0.0725 ± 0.028 ms 0.0707 ± 0.028 ms 1.03
saxpy/static workgroup=(1024,)/Float64/1024 0.059 ± 0.025 ms 0.0422 ± 0.026 ms 1.4
saxpy/static workgroup=(1024,)/Float64/1048576 0.507 ± 0.059 ms 0.496 ± 0.05 ms 1.02
saxpy/static workgroup=(1024,)/Float64/16384 0.0542 ± 0.025 ms 0.0522 ± 0.023 ms 1.04
saxpy/static workgroup=(1024,)/Float64/2048 0.0513 ± 0.023 ms 0.0437 ± 0.021 ms 1.18
saxpy/static workgroup=(1024,)/Float64/256 0.0616 ± 0.025 ms 0.0418 ± 0.025 ms 1.47
saxpy/static workgroup=(1024,)/Float64/262144 0.17 ± 0.031 ms 0.164 ± 0.029 ms 1.04
saxpy/static workgroup=(1024,)/Float64/32768 0.062 ± 0.025 ms 0.0606 ± 0.023 ms 1.02
saxpy/static workgroup=(1024,)/Float64/4096 0.0542 ± 0.026 ms 0.048 ± 0.025 ms 1.13
saxpy/static workgroup=(1024,)/Float64/512 0.0573 ± 0.025 ms 0.044 ± 0.026 ms 1.3
saxpy/static workgroup=(1024,)/Float64/64 0.0607 ± 0.025 ms 0.0446 ± 0.026 ms 1.36
saxpy/static workgroup=(1024,)/Float64/65536 0.0835 ± 0.027 ms 0.077 ± 0.026 ms 1.08
time_to_load 1.07 ± 0.0099 s 1.07 ± 0.0052 s 0.999

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (6341a45) to head (3c3d248).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/pocl/compiler/compilation.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #582   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files         21      21           
  Lines       1571    1571           
=====================================
  Misses      1571    1571           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vchuravy vchuravy force-pushed the vc/set_spirv_to_1.2 branch from 9ae09e8 to 3c3d248 Compare March 12, 2025 10:56
@vchuravy vchuravy merged commit 365bf2c into main Mar 12, 2025
7 of 12 checks passed
@vchuravy vchuravy deleted the vc/set_spirv_to_1.2 branch March 12, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant