Skip to content

Try to fix reproject tests #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Try to fix reproject tests #291

wants to merge 4 commits into from

Conversation

asinghvi17
Copy link
Member

this way we don't get hammered

@asinghvi17
Run CI on mac and windows on julia v1 at least
e589987 
this way we don't get hammered
This was referenced Apr 16, 2025
Merged
Merged
Open
Merged
@asinghvi17 asinghvi17 changed the title Run CI on mac and windows on julia v1 at least Try to fix reproject tests Apr 16, 2025
This was referenced Apr 16, 2025
Open
Open
Open
@asinghvi17 Graphite App
Copy link
Member Author

asinghvi17 commented Apr 16, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@asinghvi17
Copy link
Member Author 

Reprojecting with 2 threads
Cloned contexts successfully
0) contexts are C_NULL
Created transformations successfully
0) transformations are C_NULL
Assigned contexts to transformations successfully
Ran apply successfully
zsh: bus error  julia

this is some println debug output, so it seems as though the bus error happens at proj_destroy?

@asinghvi17
Use proj_context_destroy not proj_destroy
8d73841 
That was causing the segfault it seems.
@asinghvi17
Clean up the code and remove allocations from broadcasting
6b6ad41 
TODO: is it "safe" to use ntuple here?  is nthreads a compile time constant?  Not sure, we can leave that for later, but this is a nice note
@asinghvi17
add arch on Win
3e3aa86
@asinghvi17 asinghvi17 closed this Apr 16, 2025
@asinghvi17 asinghvi17 mentioned this pull request Apr 17, 2025
Merged
@asinghvi17 asinghvi17 deleted the as/tg_fix_reprojeect branch May 15, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asinghvi17