Fix: use jl_atomic_load_relaxed for jl_signal_thread for thread safety

ArnavKapoor · ArnavKapoor · commit bccddb05b239 · 2025-05-20T08:56:31.000+05:30
diff --git a/src/init.c b/src/init.c
@@ -557,7 +557,7 @@ static void restore_fp_env(void)
     if (jl_set_zero_subnormals(0) || jl_set_default_nans(0)) {
         jl_error("Failed to configure floating point environment");
     }
-    if (!jl_options.handle_signals && jl_n_threads > 1) {
+    if (!jl_options.handle_signals && jl_atomic_load_relaxed(&jl_n_threads) > 1) {
         jl_error("Cannot use `--handle-signals=no` with multiple threads (JULIA_NUM_THREADS > 1).\n"
         "This will cause segmentation faults due to GC safepoint failures.\n"
         "Remove `--handle-signals=no` or set JULIA_NUM_THREADS=1.\n"

Original file line number	Diff line number	Diff line change
`@@ -557,7 +557,7 @@ static void restore_fp_env(void)`
`557`	`557`	`if (jl_set_zero_subnormals(0) \|\| jl_set_default_nans(0)) {`
`558`	`558`	`jl_error("Failed to configure floating point environment");`
`559`	`559`	`}`
`560`		`- if (!jl_options.handle_signals && jl_n_threads > 1) {`
	`560`	`+ if (!jl_options.handle_signals && jl_atomic_load_relaxed(&jl_n_threads) > 1) {`
`561`	`561`	jl_error("Cannot use `--handle-signals=no` with multiple threads (JULIA_NUM_THREADS > 1).\n"
`562`	`562`	`"This will cause segmentation faults due to GC safepoint failures.\n"`
`563`	`563`	"Remove `--handle-signals=no` or set JULIA_NUM_THREADS=1.\n"