-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated functions for types resolve returned bindings in the wrong module #57417
Comments
So this particular issue is somewhat specific to that use of Core.GeneratedFunctionStub - it doesn't affect the syntax form, but we do use it as an example in the Base tests, so we should just fix it in Base. |
Keno
added a commit
that referenced
this issue
Feb 14, 2025
This addresses post-commit review #57230 (comment). This change was left-over from before I decided to also change the type of the `source` argument (at which point `source.module` was unavailable in the function). This module was supposed to be the same, but it turns out that both the julia tests and several packages use this code manually and use different modules for the two places. Use the same one we used before (which is probably more correct anyway) to fix #57417
Keno
added a commit
that referenced
this issue
Feb 15, 2025
This addresses post-commit review #57230 (comment). This change was left-over from before I decided to also change the type of the `source` argument (at which point `source.module` was unavailable in the function). This module was supposed to be the same, but it turns out that both the julia tests and several packages use this code manually and use different modules for the two places. Use the same one we used before (which is probably more correct anyway) to fix #57417
KristofferC
pushed a commit
that referenced
this issue
Feb 17, 2025
This addresses post-commit review #57230 (comment). This change was left-over from before I decided to also change the type of the `source` argument (at which point `source.module` was unavailable in the function). This module was supposed to be the same, but it turns out that both the julia tests and several packages use this code manually and use different modules for the two places. Use the same one we used before (which is probably more correct anyway) to fix #57417 (cherry picked from commit 0c5372f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Originally posted by @KristofferC in #57328
The text was updated successfully, but these errors were encountered: