don't strip keyword argument names with --strip-metadata #58412
+19
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note we don't have any tests for --strip-metadata yet; I'll see if some can be added cheaply. |
3 tasks
JeffBezanson
force-pushed
the
jb/nostripkwargnames
branch
from
9b24e20 to
1e56cef
Compare
|
Test added. |
These are used by `hasmethod`, and in any case including keyword argument symbols is unavoidable so there is no cost to keeping these.
JeffBezanson
force-pushed
the
jb/nostripkwargnames
branch
from
1e56cef to
19a8604
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used by
hasmethod, and in any case including keyword argument symbols is unavoidable so there is no cost to keeping these.