Add some precompiles to help loading time #58436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tiny PR that just shaves about 10% off Plots load time (1.1s -> 0.95s) by adding some precompiles that JLL init's hit.
I thought I'd take the opportunity to benchmark, on a M2 Pro macbook:
1.10.9
1.11.5
1.12.0-beta3
Master 43ead47
PR
And with this PR almost all loading compilation is gone
Notes
Linux is a bit faster than macOS on this M2, and I think it's #58409, which #58405 works to avoid. i.e. If I remove the dlpath calls in SuiteSparse_jll alone I get
Also, I think we should change these zero trace-compiles to indicate more clearly that they're being inferred, not compiled, AFAIU. i.e.
#= 0.0 ms =# precompile(Tuple{typeof(FFMPEG_jll.eager_mode)})