-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
docs: revise and expand ImmutableDict
docstring.
#58445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the contribution, but can we please have a more descriptive title? The current one is rather cryptic. |
Ooops! That was pretty obscure. I've updated the commit message on dict.jl following the procedure (and wincing at the warnings) given in "Changing a commit message." Will that serve? |
ImmutableDict
to list of dictionary types
Ok, I changed the title of the PR based on commit message. As reference for next time, you can do it by clicking on the "Edit" button in the top right corner of the page. |
ImmutableDict
to list of dictionary typesImmutableDict
docstring.
oh, duh. thanks for the correction and information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments / tweaks
Co-authored-by: Mason Protter <mason.protter@icloud.com>
Thanks for continuing to work on this, @rfritz! FYI, in the future you can continue using the previous pr and don't have to open a new one, that way all the conversation stays in the same place. We can keep working here now, though :) |
Co-authored-by: Mason Protter <mason.protter@icloud.com>
I had difficulty using the ImmutableDict type based on the documentation. After studying the code and reviewing advice on the Discourse site, I wrote this. This is the second version; I have made it match the style of the existing dictionary documentation and removed the tutorial content.