-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Update init.c for error on --handle-signals=no with multiple threads #58464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! No need to open a new PR (x-ref #58463), you could have pushed a new version of your changes.
Yeah but I actually made a mistake while pushing and instead pushed a new pull request. I have closed the previous one. |
|
So what should I do |
look for how it's used elsewhere, you need to use a |
@gbaraldi Corrected the file.. |
This patch adds a check during startup to disallow using --handle-signals=no when multiple threads are configured via JULIA_NUM_THREADS > 1. This avoids segmentation faults due to the GC failing to safepoint properly without signal handling, as detailed in #50278.