Skip to content

Pr 58464 #58469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Pr 58464 #58469

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f1d111
Update init.c
arnavk23 May 19, 2025
6d3e664
Merge branch 'master' into master
arnavk23 May 20, 2025
bccddb0
Fix: use jl_atomic_load_relaxed for jl_signal_thread for thread safety
May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/init.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,6 +557,12 @@ static void restore_fp_env(void)
if (jl_set_zero_subnormals(0) || jl_set_default_nans(0)) {
jl_error("Failed to configure floating point environment");
}
if (!jl_options.handle_signals && jl_atomic_load_relaxed(&jl_n_threads) > 1) {
jl_error("Cannot use `--handle-signals=no` with multiple threads (JULIA_NUM_THREADS > 1).\n"
"This will cause segmentation faults due to GC safepoint failures.\n"
"Remove `--handle-signals=no` or set JULIA_NUM_THREADS=1.\n"
"See: https://github.com/JuliaLang/julia/issues/50278");
}
}
static NOINLINE void _finish_jl_init_(jl_image_buf_t sysimage, jl_ptls_t ptls, jl_task_t *ct)
{
Expand Down