Patching the files in base and updating init.c #58495
Open
+209
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
May 22, 2025
base/asyncevent.jl
Outdated
| @@ -9,7 +9,7 @@ Create a async condition that wakes up tasks waiting for it | |||
| (by calling [`wait`](@ref) on the object) | |||
| when notified from C by a call to `uv_async_send`. | |||
| Waiting tasks are woken with an error when the object is closed (by [`close`](@ref)). | |||
| Use [`isopen`](@ref) to check whether it is still active. | |||
| Use [`isopen`](@ref) to check whether it is still active. An closed condition is inactive and will. | |||
There was a problem hiding this comment.
Besides the trailing whitespace, this sentence is incomplete
There was a problem hiding this comment.
@giordano updated all, please review the changes again.
base/asyncevent.jl
Outdated
Comment on lines
210
to
216
| """ | ||
| close(t::Union{Timer, AsyncCondition}) | ||
| Close an object `t` and thus mark it as inactive. Once a timer or condition is inactive, it will not produce a new event. | ||
| See also: [`isopen`](@ref) | ||
| """ | ||
|
|
||
| function close(t::Union{Timer, AsyncCondition}) |
There was a problem hiding this comment.
The blank line between the string and the method definition means that the string is not being attached to the method as a docstring
base/regex.jl
Outdated
Comment on lines
436
to
438
| """ | ||
|
|
||
| function match(re::Regex, str::Union{SubString{String}, String}, idx::Integer, |
There was a problem hiding this comment.
Again, blank line between string and method definition
|
I don't really understand what is going on here. These are updates to other PRs? |
|
Worked on a pr where the author has been inactive for the last year along side additions to my previous pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the pull requests #58464 and #58020, I have updated files in base and init.c for #50278 and #58020.