tiny PR to fix writeshortest for 0.0 when hash==false #58502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digital-carver
force-pushed
the
dc/ryu0fix
branch
from
47a96aa to
272f5db
Compare
|
Needs a test |
|
The fix LGTM once a test is added. Thanks, @digital-carver! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
The second 0 is intended to be printed when the last argument
hashistrueand a decimal point is printed, to follow that.(i.e."0.0"). But it's currently printed also whenhashisfalse, resulting in this function not printing the actual "shortest" numeric string for this case.(issue first noted by Dave MacMahon on Slack)