Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ValidationLieGroup #22

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Conversation

kellertuer
Copy link
Member

@kellertuer kellertuer commented Feb 23, 2025

📋

This PR aims to provide the analogue of a ValidationManifold for Lie groups. Internally one can (but does not have to) add such a validation also for the inner manifold functions.

  • implement the Lie groups interface
  • 📚 adapt docs
  • resolve ambiguties
  • test coverage

@kellertuer
Copy link
Member Author

This basically just needs a few functions to be defined for the LieAlgebra of a ValidatinLieGroup to handle wrapped points a bit – and a careful check, whether or not Identity(G) should be wrapped as ValidationMPoint(Identity(G)) or not.

@kellertuer
Copy link
Member Author

kellertuer commented Feb 28, 2025

Decided again st wrapping identity, since that causes too much strange side effects on the system.

@kellertuer kellertuer added the Ready-for-Review A label for pull requests that are feature-ready label Feb 28, 2025
@kellertuer
Copy link
Member Author

I consider this ready for review, since the only thing that should be missing by now is a few test coverage corner cases.

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 86.15023% with 59 lines in your changes missing coverage. Please review.

Project coverage is 96.79%. Comparing base (5e478f3) to head (4f66962).

Files with missing lines Patch % Lines
src/groups/validation_group.jl 84.22% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   99.50%   96.79%   -2.72%     
==========================================
  Files          21       22       +1     
  Lines        1625     1996     +371     
==========================================
+ Hits         1617     1932     +315     
- Misses          8       64      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready-for-Review A label for pull requests that are feature-ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant