-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a ValidationLieGroup #22
base: main
Are you sure you want to change the base?
Conversation
This basically just needs a few functions to be defined for the |
Decided again st wrapping identity, since that causes too much strange side effects on the system. |
I consider this ready for review, since the only thing that should be missing by now is a few test coverage corner cases. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 99.50% 96.79% -2.72%
==========================================
Files 21 22 +1
Lines 1625 1996 +371
==========================================
+ Hits 1617 1932 +315
- Misses 8 64 +56 ☔ View full report in Codecov by Sentry. |
📋
This PR aims to provide the analogue of a
ValidationManifold
for Lie groups. Internally one can (but does not have to) add such a validation also for the inner manifold functions.