Stack overflow error when comparing Polynomial and RationalFunction

[Fabi293]

When I try to compare a polynomial p with a rational function r, I get a stackoverflow error:

using Polynomials

p = Polynomial([0,1])
r = p//1

r ≈ p
# r==p  # works

ERROR: LoadError: StackOverflowError:
Stacktrace:
[1] GenericMemory
@ .\boot.jl:516 [inlined]
[2] Array
@ .\boot.jl:578 [inlined]
[3] Array
@ .\boot.jl:591 [inlined]
[4] similar
@ .\abstractarray.jl:868 [inlined]
[5] similar
@ .\abstractarray.jl:867 [inlined]
[6] _array_for
@ .\array.jl:676 [inlined]
[7] _array_for
@ .\array.jl:679 [inlined]
[8] Polynomial{Int64, :x}(::Val{true}, cs::Vector{Int64}, order::Int64)
@ Polynomials USER.julia\packages\Polynomials\Uyrf2\src\polynomial-container-types\mutable-dense-polynomial.jl:16
[9] MutableDensePolynomial (repeats 2 times)
@ USER.julia\packages\Polynomials\Uyrf2\src\polynomial-container-types\mutable-dense-polynomial.jl:29 [inlined]
[10] one
@ USER.julia\packages\Polynomials\Uyrf2\src\polynomials\standard-basis\standard-basis.jl:30 [inlined]
[11] one
@ USER.julia\packages\Polynomials\Uyrf2\src\common.jl:967 [inlined]
[12] one (repeats 2 times)
@ USER.julia\packages\Polynomials\Uyrf2\src\common.jl:968 [inlined]
[13] *(p::RationalFunction{Int64, :x, Polynomial{Int64, :x}}, q::Polynomial{Int64, :x})
@ Polynomials USER.julia\packages\Polynomials\Uyrf2\src\rational-functions\common.jl:320
[14] isapprox(p1::Polynomial{Int64, :x}, n::RationalFunction{Int64, :x, Polynomial{Int64, :x}}; kwargs::@kwargs{})
@ Polynomials USER.julia\packages\Polynomials\Uyrf2\src\common.jl:1350
[15] isapprox(p1::Polynomial{Int64, :x}, n::RationalFunction{Int64, :x, Polynomial{Int64, :x}})
@ Polynomials USER.julia\packages\Polynomials\Uyrf2\src\common.jl:1350--- the above 2 lines are repeated 39988 more times ---

[jverzani]

Thanks! This is a missing specialized dispatch. I hope to fix soon.