Skip to content

Commit 64f0414

Browse files
anrisethpkofod
authored andcommitted
Don't filter example tests based on environment. (#116)
Travis, AppVeyor, and CIBot all fail when there are breaking changes between LineSearches and downstream packages, such as Optim, that are also used in the examples. Instead of filtering tests based on CI environment, we'll just have to remember to add the tests back when the most recent downstream application works.
1 parent ca3ce1a commit 64f0414

File tree

2 files changed

+6
-16
lines changed

2 files changed

+6
-16
lines changed

docs/generate.jl

+3-8
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
11
# generate examples
22
import Literate
33

4-
# We shouldn't run the examples that require Optim in Travis/CI,
5-
# because an update in LineSearches may be breaking with the
6-
# most recently tagged Optim version.
7-
if get(ENV, "CI", "") == "true"
8-
ONLYSTATIC = ["optim_linesearch.jl", "optim_initialstep.jl"]
9-
else
10-
ONLYSTATIC = ["",]
11-
end
4+
# TODO: Remove items from `SKIPFILE` as soon as they run on the latest
5+
# stable `Optim` (or other dependency)
6+
ONLYSTATIC = ["optim_linesearch.jl", "optim_initialstep.jl"]
127

138
EXAMPLEDIR = joinpath(@__DIR__, "src", "examples")
149
GENERATEDDIR = joinpath(@__DIR__, "src", "examples", "generated")

test/examples.jl

+3-8
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,7 @@
11
@testset "Literate examples" begin
2-
# We shouldn't run the examples that require Optim in Travis/CI,
3-
# because an update in LineSearches may be breaking with the
4-
# most recently tagged Optim version.
5-
if get(ENV, "CI", "") == "true"
6-
SKIPFILE = ["optim_linesearch.jl", "optim_initialstep.jl"]
7-
else
8-
SKIPFILE = ["",]
9-
end
2+
# TODO: Remove items from `SKIPFILE` as soon as they run on the latest
3+
# stable `Optim` (or other dependency)
4+
SKIPFILE = ["optim_linesearch.jl", "optim_initialstep.jl"]
105

116
EXAMPLEDIR = joinpath(@__DIR__, "../docs/src/examples")
127

0 commit comments

Comments
 (0)