Deprecate (but do not remove) the Slurm functionality in this package (and point users to SlurmClusterManager.jl instead) #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilumAluthge
force-pushed
the
dpa/deprecate-but-do-not-remove-slurm-in-this-package
branch
from
c46a7a1 to
d558a54
Compare
1 task
DilumAluthge
force-pushed
the
dpa/deprecate-but-do-not-remove-slurm-in-this-package
branch
from
577ee74 to
d558a54
Compare
DilumAluthge
force-pushed
the
dpa/deprecate-but-do-not-remove-slurm-in-this-package
branch
from
d558a54 to
c82f5fe
Compare
DilumAluthge
force-pushed
the
dpa/deprecate-but-do-not-remove-slurm-in-this-package
branch
from
c82f5fe to
6b1af89
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
==========================================
+ Coverage 37.62% 37.85% +0.22%
==========================================
Files 7 7
Lines 388 391 +3
==========================================
+ Hits 146 148 +2
- Misses 242 243 +1 ☔ View full report in Codecov by Sentry. |
|
@kleinhenz What are your thoughts on moving forward with this? |
DilumAluthge
force-pushed
the
dpa/deprecate-but-do-not-remove-slurm-in-this-package
branch
from
6b1af89 to
cbeb2dc
Compare
… (and point users to SlurmClusterManager.jl instead)
DilumAluthge
force-pushed
the
dpa/deprecate-but-do-not-remove-slurm-in-this-package
branch
from
cbeb2dc to
b35ad48
Compare
|
Bump @kleinhenz - Shall we move forward with merging this PR and making a new release of ClusterManagers.jl? |
DilumAluthge
requested review from
kleinhenz
and removed request for
kleinhenz
|
That makes sense to me |
kleinhenz
approved these changes
Feb 15, 2025
DilumAluthge
deleted the
dpa/deprecate-but-do-not-remove-slurm-in-this-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
We'll first release a non-breaking release of ClusterManagers.jl with the deprecation warning.
Then, we'll follow-up with a breaking release of ClusterManagers.jl that fully removes the Slurm functionality from this package.
The README (of this package) will point users to the SlurmClusterManager.jl package instead.