Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Move SGE docs from README to separate file #248

Merged
merged 3 commits into from
Feb 10, 2025

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Feb 9, 2025

The SGE functionality in this package is not currently being maintained, so I don't think we should present the SGE docs up-front in the README.

Instead, let's put the SGE docs in a separate Markdown file.


Depends on:

@DilumAluthge DilumAluthge changed the base branch from dpa/deprecate-but-do-not-remove-slurm-in-this-package to dpa/deprecate-unsupported-managers February 9, 2025 23:11
@DilumAluthge DilumAluthge force-pushed the dpa/readme-deprecated branch from bdef779 to 29e5972 Compare February 9, 2025 23:16
@DilumAluthge DilumAluthge force-pushed the dpa/deprecate-unsupported-managers branch from 446f970 to 14fbe35 Compare February 9, 2025 23:16
@DilumAluthge DilumAluthge force-pushed the dpa/readme-deprecated branch from 29e5972 to d27e7c8 Compare February 9, 2025 23:30
@DilumAluthge DilumAluthge force-pushed the dpa/deprecate-unsupported-managers branch from 14fbe35 to 9808d41 Compare February 10, 2025 00:03
Base automatically changed from dpa/deprecate-unsupported-managers to master February 10, 2025 00:06
@DilumAluthge DilumAluthge marked this pull request as ready for review February 10, 2025 00:12
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.62%. Comparing base (d3b5c22) to head (5c74c82).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   37.62%   37.62%           
=======================================
  Files           7        7           
  Lines         388      388           
=======================================
  Hits          146      146           
  Misses        242      242           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DilumAluthge DilumAluthge merged commit 732c86c into master Feb 10, 2025
10 checks passed
@DilumAluthge DilumAluthge deleted the dpa/readme-deprecated branch February 10, 2025 00:18
DilumAluthge added a commit that referenced this pull request Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant