Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting minor grid and minor ticks #1794

Closed
greimel opened this issue Oct 16, 2018 · 2 comments · Fixed by #2621
Closed

Supporting minor grid and minor ticks #1794

greimel opened this issue Oct 16, 2018 · 2 comments · Fixed by #2621

Comments

@greimel
Copy link
Contributor

greimel commented Oct 16, 2018

Is it the case that gr() is the only backend that support minor grids at the moment? Is backends.jl the place to look? The only attributes containing *minor* are in gr(). I tried pyplot() and pgfplots() seem to ignore minorgrid = true.

If minor grids and minor ticks were to be implemented for other backends (and, possibly, in Makie.jl), I would like to be able to control major and minor ticks separately.

In #1788 I implemented two new attributes foreground_color_tick and foreground_color_minor_tick and incorporated them in the gr() backend.

plot(rand(10), rand(10), foreground_color_tick = :green, foreground_color_minortick=:red, minorgrid=true)

gr-tick-colors

I propose to replace the foreground_color_axis attribute with these two attributes. (The color of the axis is determined by foreground_color_axis.

Should I extend #1788 to replace foreground_color_axis in the other backends?

@daschw
Copy link
Member

daschw commented Oct 18, 2018

Minor and major ticks grids where only implemented some months ago for GR and GLVisualize (they share the same code for drawing segments for axes, grids, ticks, etc.) in #1596.
So #1788 cannot really be extended for the other backends, right?

@daschw
Copy link
Member

daschw commented Oct 18, 2018

I'm sorry, of course foreground_color_tick can be extended to the other backends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants