Add support for comparing commits. #202
Conversation
maleadt
force-pushed
the
compare
branch
2 times, most recently
from
a72ae68 to
b009260
Compare
|
CI failure unrelated, should be fixed by #203 (I'd base this PR on that, but can't use a base that outside of this repo). cc @logankilpatrick @quinnj for review |
| permalink_url::Union{URIs.URI, Nothing} | ||
| diff_url::Union{URIs.URI, Nothing} | ||
| patch_url::Union{URIs.URI, Nothing} | ||
| base_commit::Union{Commit, Nothing} |
There was a problem hiding this comment.
I think this is deprecated, if that matters
There was a problem hiding this comment.
I don't think it matters. We're just encoding the response here, so I guess it doesn't hurt if that includes deprecated fields (where did you find this?). They will just be set to nothing if the API stops returning them.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 56.54% 56.39% -0.15%
==========================================
Files 36 37 +1
Lines 856 860 +4
==========================================
+ Hits 484 485 +1
- Misses 372 375 +3 ☔ View full report in Codecov by Sentry. |
No description provided.