Find releases past all-filtered-out pages on GitHub #4319
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a netkan has an
asset_match
that filters out the entire first page of releases on GitHub, then releases on later pages won't be found.At the moment this only affects RP-0, which last had a matching release (starting with
v1
) six pages (19 months) ago:(We might want to freeze that one anyway, if it's never going to have another release and is costing us 6 API hits per inflation...)
Cause
#4318 refactored the GitHub API to make a
GithubRelease
object accurately reflect the upstream data instead of processing it, which required moving the filtering logic fromGithubRelease
's constructor toGithubApi.GetAllReleases
. In the process, the empty-page check was moved after the filtering instead of before, so the loop stopped at the first all-filtered-out page.Changes
Now the empty-page check happens before the filtering.