Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find releases past all-filtered-out pages on GitHub #4319

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

HebaruSan
Copy link
Member

Problem

If a netkan has an asset_match that filters out the entire first page of releases on GitHub, then releases on later pages won't be found.

At the moment this only affects RP-0, which last had a matching release (starting with v1) six pages (19 months) ago:

(We might want to freeze that one anyway, if it's never going to have another release and is costing us 6 API hits per inflation...)

Cause

#4318 refactored the GitHub API to make a GithubRelease object accurately reflect the upstream data instead of processing it, which required moving the filtering logic from GithubRelease's constructor to GithubApi.GetAllReleases. In the process, the empty-page check was moved after the filtering instead of before, so the loop stopped at the first all-filtered-out page.

Changes

Now the empty-page check happens before the filtering.

@HebaruSan HebaruSan merged commit 27c6d9a into KSP-CKAN:master Feb 22, 2025
2 checks passed
@HebaruSan HebaruSan deleted the fix/release-filters branch February 22, 2025 04:35
@HebaruSan HebaruSan added Bug Something is not working as intended Netkan Issues affecting the netkan data labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Netkan Issues affecting the netkan data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant