Fixes #38218 - use proper version_href on repos outside CV filters #11313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
pmoravec
force-pushed
the
cv-depsolve-filters-wrong-pulp-repo
branch
from
7de3b8d to
fdda369
Compare
|
The test fails in a setup phase (https://github.com/Katello/katello/blob/master/test/lib/util/errata_test.rb#L41), I doubt this can be relevant to my PR..? |
|
Works well... Ack! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
On CVs with depsolving and filters applied just to some repos, the remaining repos must reuse version_href from source repo.
Considerations taken when implementing this change?
Maybe we can merge the added code with almost identical code block few lines below? (unsure what all call flows use it)
What are the testing steps for this pull request?
See the Katello bug for details.