Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38226 - image mode column title should be Type #11319

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

ianballou
Copy link
Member

What are the changes introduced in this pull request?

Changes the column title for host type to be "Type" instead of the image mode icon.

Considerations taken when implementing this change?

...

What are the testing steps for this pull request?

Enable the Type column, make sure it looks like:
image

Make sure the popover says "Image mode / package mode".

(cherry picked from commit f12c6cd6ceeb7b9d23653db05f1a9520c40239ca)
Copy link
Contributor

@sambible sambible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I literally had a note to ask about this but forgot :)

@sjha4
Copy link
Member

sjha4 commented Feb 19, 2025

Ack..Works as advertised. 👍🏼

Screenshot from 2025-02-19 08-47-40

@ianballou ianballou merged commit bbbf9e0 into Katello:master Feb 20, 2025
18 of 19 checks passed
@ianballou ianballou deleted the image-mode-icon-column-new-name branch February 20, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants