-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change license from GPL-3.0 to a more general #2
Comments
I have to admit that I'm not confident with licensing. My first though was to use the MIT license. Except ... Actually, before producing these plugins, I found a Javascript/JS code that produces Voronoï treemaps for D3 version 3 (cf. https://bl.ocks.org/mkedwards/759e719eefe36cf9c8ab). I've reworked it (i.e. refactored, bug-fixed, unit-tested) to make it available for D3 version 4 (cf. https://bl.ocks.org/kcnarf/15d54f4ccae6a3710cd3029546664eec). Based on this first experience, I've decided to produce this d3-voronoi-treemap plugin, as it is a more packaged and easy-to-use solution with clearly defined APIs. Later, I realized that the JS code I've found came from another work, available in the fp-plvines-djpeter Github repository. Authors clearly state that they wanted their code to be shared and used by others. The main issue is that this JS code is not under any license, meaning that it is proprietory code. Even later, I realized that this former Js code was based on a Java implementation (available in the power-voronoi-diagram Github repository) which is under the GPL-3.0 license. This Java implementation was written by one of the co-authors of the scientific paper which specifies the overall algorithm used for this d3-voronoi-treemap plug-in. ==> Hence, I've decided to make this d3-voronoi-treemap plugin under the GPL-3.0 license (the license of the Java implementation). Probably that I have to ask the authors of the JS and Java implementations about this concern. |
@Kcnarf thanks for making this issue 😄 |
thanks @Kcnarf for considering my request. Any idea how long it will take to change the license to MIT ? @micahstubbs - Thanks for clarification. I am not going to distribute it. My only requirement is to use this code as is to generate weighted voronoi chart. There is no intention to modify or sell the code.The website would be available publicly. . |
@Svmali84 I can't tell you how long it will take :-( I'm on it ... |
@Svmali84 you can probably use the GPL-3 code now with a clean conscience. without distributing the result, you should be with terms of the license. |
for other use cases, it would be nice to have a more liberal license, if the author of the Java implementation is willing to grant one (or if @Kcnarf decides that this js implementation is different enough from the Java implementation that he can just pick a new license for it himself...) |
@micahstubbs thanks. Yes I am not going to distribute the result.But even after reading the GPL terms ,I am not getting how to use GPLed javascript on my website.Is putting copyright notice on top of script is sufficient? Also I am not sure which copyright notice I need to put exactly. |
FYI, |
@micahstubbs do you have pointers that may help to decide if two implementations are different enough ? |
As I understand GPL-3.0:
Useful links: |
@Kcnarf - Thank you. Few questions:
|
@SSCodeChamp - Good question :-) On one hand, if the code is executed server side (with NodeJS), there is no trouble. On the other hand, when the code is delivered by the server and executed client side, my opinion is that there is also no trouble: it is the way JS works. Intermediate technologies (browser, browser plugins, JS frameworks, ...) execute your code in order to produce the final result for the end user. Its obvious that intermediate technologies which are not under GPL-3.0 (notably browsers) can execute third party code under GPL-3.0 license. My opinion is that there is no entent to convey the code, there is no intent to authorize third party users to reuse your code. If someone reuse your code this way, I think it is considered a non-legal way to obtain that code (i.e. a non-legal copy of that code), without the appropriate rights to use it. Note that minifying the delivered code can limit its steal. |
Thanks @Kcnarf . So what pointers (putting copyright notice etc..) I should consider while using below your JS files for generating voronoi treemap similar to https://bl.ocks.org/Kcnarf/fa95aa7b076f537c00aed614c29bb568 <script src="https://raw.githack.com/Kcnarf/d3-weighted-voronoi/master/build/d3-weighted-voronoi.js"></script> <script src="https://raw.githack.com/Kcnarf/d3-voronoi-map/master/build/d3-voronoi-map.js"></script> <script src="https://raw.githack.com/Kcnarf/d3-voronoi-treemap/master/build/d3-voronoi-treemap.js"></script> |
I have very good news for the D3 community :
Many thanks to them for sharing their work. I will soon move the plugin under a BSD-3-clause license, as D3 is. |
Thanks @Kcnarf for taking this effort. Untill the license change to use above JS files can you please answer my above questions |
The plugin is now under the BSD-3-Clause, as D3 is.
|
Thanks @Kcnarf . |
This issue is a continuation of a discussion initiated in the d3/d3-voronoi's issue#5.
Summary of previous discussion :
@Svmali84 - So can I make use of it (i.e. d3-voronoi-treemap) on my website free ? I see it is under GPL-3 license. So putting copyright is sufficient ?
@micahstubbs - I imagine that you can use it so long as you do not distribute it. this stackoverflow answer may help 😄 https://stackoverflow.com/a/2281266/1732222
@micahstubbs - we could also ask @Kcnarf if he would be willing to release d3-voronoi under a more liberal license, like for example the BSD-3-Clause license that d3 itself is released under or the popular MIT license
The text was updated successfully, but these errors were encountered: