Skip to content

LinearGroupByKey could allow provided closure to borrow from input #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ten0 opened this issue Aug 16, 2023 · 2 comments · May be fixed by #26
Open

LinearGroupByKey could allow provided closure to borrow from input #25

Ten0 opened this issue Aug 16, 2023 · 2 comments · May be fixed by #26
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ten0
Copy link

Ten0 commented Aug 16, 2023

Current:

fn linear_group_by_key<F, K>(&self, func: F) -> LinearGroupByKey<T, F>
    where F: FnMut(&T) -> K,
          K: PartialEq

Does not allow:

let strings = vec!["A".to_owned()];
strings.linear_group_by_key(|s| s.as_str());

In order for that to work, we need:

fn linear_group_by_key<'a, F, K>(&'a self, func: F) -> LinearGroupByKey<T, F>
    where F: FnMut(&'a T) -> K,
          K: PartialEq

Since nothing moves in memory it should be possible.
@Kerollmops
Copy link
Owner

Hey @Ten0 👋

That's a great idea, and it is not breaking. Can you please propose a pull request and even copy/paste your comment into this official thread, too?

@Kerollmops Kerollmops added enhancement New feature or request good first issue Good for newcomers labels Dec 14, 2023
@Ten0 Ten0 mentioned this issue Dec 14, 2023
Closed
3 tasks
@CodeMan62
Copy link

Hii @Kerollmops Let me pick this up.

@CodeMan62 CodeMan62 linked a pull request Apr 7, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LinearGroupByKey could allow provided closure to borrow from input CodeMan62/slice-group-by
3 participants
@Kerollmops @Ten0 @CodeMan62