Add support for pointer types in vector when using extension SPV_INTEL_masked_gather_scatter #6041
+66
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
VishMCW
force-pushed
the
spv_intel_masked_gather_scatter
branch
2 times, most recently
from
f47a194 to
79c0a9c
Compare
alan-baker
requested changes
Mar 31, 2025
VishMCW
force-pushed
the
spv_intel_masked_gather_scatter
branch
from
79c0a9c to
568c47b
Compare
alan-baker
requested changes
Apr 1, 2025
source/val/validate_type.cpp
Outdated
| bool isPointer = component_type->opcode() == spv::Op::OpTypePointer; | ||
| bool isScalar = spvOpcodeIsScalarType(component_type->opcode()); | ||
|
|
||
| if (_.HasExtension(Extension::kSPV_INTEL_masked_gather_scatter) && |
There was a problem hiding this comment.
I think strictly speaking this should be capability gated by the spec:
Suggested change
| if (_.HasExtension(Extension::kSPV_INTEL_masked_gather_scatter) && | |
| if (_.HasCapability(spv::Capability::MaskedScatterGatherINTEL) && |
There was a problem hiding this comment.
I have made the changes to use capability instead of extension
source/val/validate_type.cpp
Outdated
| << _.getIdName(component_id) | ||
| << ": Expected a scalar or pointer type when using the " | ||
| "SPV_INTEL_masked_gather_scatter extension."; | ||
| } else if (!_.HasExtension(Extension::kSPV_INTEL_masked_gather_scatter) && |
There was a problem hiding this comment.
Same as above.
Suggested change
| } else if (!_.HasExtension(Extension::kSPV_INTEL_masked_gather_scatter) && | |
| } else if (!_.HasCapability(spv::Capability::MaskedScatterGatherINTEL) && |
MaskedGatherScatterINTEL is enabled Add supporting tests for spv_intel_masked_gather_scatter Formatting changes for unrelated files
VishMCW
force-pushed
the
spv_intel_masked_gather_scatter
branch
from
568c47b to
62c6ecf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
current checks in spirv-val only check for vector types that are scalar, on using extension SPV_INTEL_masked_gather_scatter OpTypeVector must also support pointer types
check spec: SPV_INTEL_masked_gather_scatter