GN build: Define VK_USE_PLATFORM_XLIB_KHR #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to define vkCreateXlibSurfaceKHR, which is required by GTK4. Depends on Dawn CL: https://dawn-review.googlesource.com/c/dawn/+/229494 Needed to fix this Chromium issue: https://g-issues.chromium.org/issues/345261080
|
|
charles-lunarg
approved these changes
Mar 6, 2025
hubot
pushed a commit
to google/angle
that referenced
this pull request
Mar 7, 2025
Manual roll requested by ynovikov@google.com Due to KhronosGroup/Vulkan-Headers#534 including <vulkan/vulkan.h> now causes <X11/Xlib.h> to be included, which breaks the build because of the macros it defines. To workaround, undefine these macros after vulkan.h include. https://chromium.googlesource.com/vulkan-deps.git/+log/4f7de8f463f8..d34de7171c18 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/952f776f6573aafbb62ea717d871cd1d6816c387..0f0cfd88d7e6ece3ca6456df692f0055bde94be7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-angle-autoroll Please CC angle-team@google.com,solti@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:345261080 Change-Id: Ib229dc03e7b33daf817e3248025fdcab64157e1e Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/6334528 Reviewed-by: Solti Ho <solti@google.com> Commit-Queue: Solti Ho <solti@google.com>
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 18, 2025
Manual roll requested by ynovikov@google.com Due to KhronosGroup/Vulkan-Headers#534 including <vulkan/vulkan.h> now causes <X11/Xlib.h> to be included, which breaks the build because of the macros it defines. To workaround, undefine these macros after vulkan.h include. https://chromium.googlesource.com/vulkan-deps.git/+log/4f7de8f463f8..d34de7171c18 Also rolling transitive DEPS: https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/952f776f6573aafbb62ea717d871cd1d6816c387..0f0cfd88d7e6ece3ca6456df692f0055bde94be7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC angle-team@google.com,cwallez@google.com,geofflang@google.com,radial-bots+chrome-roll@google.com,radial-bots@google.com,webgpu-developers@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86;luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:win-asan;luci.chromium.try:linux_chromium_cfi_rel_ng Bug: 345261080 Change-Id: I8892ba56563f5d6cf21bd2d7b5882163d5dff356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6359023 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by: Victor Miura <vmiura@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Peter McNeeley <petermcneeley@google.com> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1434234}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to define vkCreateXlibSurfaceKHR, which is required by GTK4.
Depends on Dawn CL:
https://dawn-review.googlesource.com/c/dawn/+/229494
Needed to fix this Chromium issue:
https://g-issues.chromium.org/issues/345261080