Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed backfaces, adjusted diffuseTransmission #165

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

echadwick-artist
Copy link
Contributor

screenshot_Large

  • Leaf backfaces removed, and doubleSided:true used instead, to allow pathtracers to render this asset effectively. (Previously the asset was relying on backface culling to render properly, but this is not supported in most pathtracers, which makes it impossible to check for ground truth.)
  • baseColorTexture edited so veins are now red. (to help communicate the idea that the leaves are red inside, and thus would show red-colored diffuse transmission)
  • Firefly2 animation changed to counter-clockwise, to make it very different from Firefly1.
  • Asset re-exported from 3ds Max, and re-optimized with RapidPipeline.
  • Textures packed into single shared UV layout, and ambient occlusion re-baked.
  • diffuseTransmissionTexture added, to show transmission on stems and leaf veins.

* Leaf backfaces removed, and doubleSided:true used instead, to allow pathtracers to render this asset effectively.
* baseColorTexture edited so veins are now red.
* Firefly2 animation changed to counter-clockwise, to make it very different from Firefly1.
* Asset re-exported from 3ds Max, and re-optimized with RapidPipeline.
* Textures packed into single shared UV layout, and ambient occlusion re-baked.
* diffuseTransmissionTexture added, to show transmission on stems and leaf veins.
@DRx3D
Copy link
Contributor

DRx3D commented Feb 10, 2025

Since this is an existing asset, should the README be updated with a description of the changes to the model?

@echadwick-artist
Copy link
Contributor Author

I guess I should add something about doubleSided vs. doubled triangles and how that works better with pathtracers, good suggestion.

Added more info to the readme about the use of doubleSided, and the diffuseTransmissionTexture.
@UX3D-haertl
Copy link

The diffuseTransmissionTexture does not use the alpha channel, which is the relevant channel.

A texture that defines the percentage of non-specularly reflected light that is diffusely transmitted through the surface. Stored in the alpha (A) channel. Will be multiplied by the diffuseTransmissionFactor.

The plant material has been adjusted to work better with the current glTF Sample Viewer shader, primarily to reduce diffuse transmission, but also to fix an erroneous diffuseTransmissionTexture (which didn't contain an alpha channel).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants