Add setPermission support (#122)

Author: Kimahriman

python/hdfs_native/__init__.py

@@ -151,3 +151,10 @@ def set_owner(
         Sets the owner and/or group for the file at `path`
         """
         return self.inner.set_owner(path, owner, group)
+
+    def set_permission(self, path: str, permission: int) -> None:
+        """
+        Sets the permissions for file at `path` to the octal value `permission`.
+        For example, to set "rw-r--r--" Unix style permissions, use permission=0o644.
+        """
+        return self.inner.set_permission(path, permission)

python/hdfs_native/_internal.pyi

@@ -60,3 +60,4 @@ class RawClient:
         owner: Optional[str],
         group: Optional[str],
     ) -> None: ...
+    def set_permission(self, path: str, permission: int) -> None: ...

python/src/lib.rs

@@ -262,6 +262,12 @@ impl RawClient {
     ) -> PyHdfsResult<()> {
         Ok(self.rt.block_on(self.inner.set_owner(path, owner, group))?)
     }
+
+    pub fn set_permission(&self, path: &str, permission: u32) -> PyHdfsResult<()> {
+        Ok(self
+            .rt
+            .block_on(self.inner.set_permission(path, permission))?)
+    }
 }
 
 /// A Python module implemented in Rust.

python/tests/test_integration.py

@@ -82,4 +82,9 @@ def test_integration(minidfs: str):
     assert file_info.owner == "testuser2"
     assert file_info.group == "testgroup2"
 
+    assert file_info.permission == 0o644
+    client.set_permission("/testfile", 0o600)
+    file_info = client.get_file_info("/testfile")
+    assert file_info.permission == 0o600
+
     client.delete("/testfile", False)

rust/src/client.rs

@@ -22,8 +22,8 @@ pub struct WriteOptions {
     pub block_size: Option<u64>,
     /// Replication factor. Default is retrieved from the server.
     pub replication: Option<u32>,
-    /// Unix file permission, defaults to 0o755. This is the raw octal
-    /// value represented in base 10.
+    /// Unix file permission, defaults to 0o644, which is "rw-r--r--" as a Unix permission.
+    /// This is the raw octal value represented in base 10.
     pub permission: u32,
     /// Whether to overwrite the file, defaults to false. If true and the
     /// file does not exist, it will result in an error.
@@ -38,7 +38,7 @@ impl Default for WriteOptions {
         Self {
             block_size: None,
             replication: None,
-            permission: 0o755,
+            permission: 0o644,
             overwrite: false,
             create_parent: true,
         }
@@ -445,6 +445,24 @@ impl Client {
             .await?;
         Ok(())
     }
+
+    /// Sets permissions for a file. Permission should be an octal number reprenting the Unix style
+    /// permission.
+    ///
+    /// For example, to set permissions to rwxr-xr-x:
+    /// ```rust
+    /// # async fn func() {
+    /// # let client = hdfs_native::Client::new("localhost:9000").unwrap();
+    /// client.set_permission("/path", 0o755).await.unwrap();
+    /// }
+    /// ```
+    pub async fn set_permission(&self, path: &str, permission: u32) -> Result<()> {
+        let (link, resolved_path) = self.mount_table.resolve(path);
+        link.protocol
+            .set_permission(&resolved_path, permission)
+            .await?;
+        Ok(())
+    }
 }
 
 impl Default for Client {

rust/src/hdfs/protocol.rs

@@ -435,6 +435,28 @@ impl NamenodeProtocol {
         debug!("setOwner response: {:?}", &decoded);
         Ok(decoded)
     }
+
+    pub(crate) async fn set_permission(
+        &self,
+        src: &str,
+        permission: u32,
+    ) -> Result<hdfs::SetPermissionResponseProto> {
+        let message = hdfs::SetPermissionRequestProto {
+            src: src.to_string(),
+            permission: hdfs::FsPermissionProto { perm: permission },
+        };
+
+        debug!("setPermission request: {:?}", &message);
+
+        let response = self
+            .proxy
+            .call("setPermission", message.encode_length_delimited_to_vec())
+            .await?;
+
+        let decoded = hdfs::SetPermissionResponseProto::decode_length_delimited(response)?;
+        debug!("setPermission response: {:?}", &decoded);
+        Ok(decoded)
+    }
 }
 
 impl Drop for NamenodeProtocol {

rust/tests/test_integration.rs

@@ -189,6 +189,7 @@ mod test {
         test_recursive_listing(&client).await?;
         test_set_times(&client).await?;
         test_set_owner(&client).await?;
+        test_set_permission(&client).await?;
 
         Ok(())
     }
@@ -381,6 +382,27 @@ mod test {
         assert_eq!(file_info.owner, "testuser2");
         assert_eq!(file_info.group, "testgroup2");
 
+        client.delete("/test", false).await?;
+
+        Ok(())
+    }
+
+    async fn test_set_permission(client: &Client) -> Result<()> {
+        client
+            .create("/test", WriteOptions::default())
+            .await?
+            .close()
+            .await?;
+
+        let file_info = client.get_file_info("/test").await?;
+        assert_eq!(file_info.permission, 0o644);
+
+        client.set_permission("/test", 0o600).await?;
+        let file_info = client.get_file_info("/test").await?;
+        assert_eq!(file_info.permission, 0o600);
+
+        client.delete("/test", false).await?;
+
         Ok(())
     }
 }