Switch to ruff instead of black and isort

Author: Kimahriman

.github/workflows/python-test.yml

@@ -56,8 +56,8 @@ jobs:
         run: |
           source .venv/bin/activate
           mypy
-          isort . --check
-          black . --check
+          ruff check .
+          ruff format . --check --diff
 
       - name: Run tests
         run: |

python/conftest.py

@@ -4,6 +4,7 @@
 
 import fsspec
 import pytest
+
 from hdfs_native import Client
 from hdfs_native.fsspec import HdfsFileSystem
 
@@ -35,7 +36,7 @@ def minidfs():
 
     try:
         child.communicate(input="\n", timeout=30)
-    except:
+    except:  # noqa: E722
         child.kill()
 
 

python/hdfs_native/__init__.py

@@ -1,15 +1,17 @@
 import io
 import os
-from typing import Dict, Iterator, Optional
+from typing import TYPE_CHECKING, Dict, Iterator, Optional
 
 # For some reason mypy doesn't think this exists
 from typing_extensions import Buffer  # type: ignore
 
-from ._internal import *
+from ._internal import RawClient, WriteOptions
 
+if TYPE_CHECKING:
+    from ._internal import ContentSummary, FileStatus, RawFileReader, RawFileWriter
 
-class FileReader(io.RawIOBase):
 
+class FileReader(io.RawIOBase):
     def __init__(self, inner: "RawFileReader"):
         self.inner = inner
 
@@ -64,7 +66,6 @@ def close(self) -> None:
 
 
 class FileWriter(io.RawIOBase):
-
     def __init__(self, inner: "RawFileWriter"):
         self.inner = inner
 
@@ -87,7 +88,6 @@ def __exit__(self, *_args):
 
 
 class Client:
-
     def __init__(
         self,
         url: Optional[str] = None,

python/pyproject.toml

@@ -20,11 +20,9 @@ dependencies = [
 
 [project.optional-dependencies]
 devel = [
-    "mypy~=1.8.0",
-    "ruff~=0.4.8",
-    "pytest~=7.4",
-    "black~=24.4",
-    "isort~=5.13"
+    "mypy~=1.13.0",
+    "ruff~=0.7.2",
+    "pytest~=8.3",
 ]
 
 [project.urls]
@@ -53,3 +51,6 @@ testpaths = [
     "tests",
     "hdfs_native",
 ]
+
+[tool.ruff.lint]
+extend-select = ["I"] 

python/tests/test_fsspec.py

@@ -2,29 +2,24 @@
 
 import fsspec
 import pytest
+
 from hdfs_native.fsspec import HdfsFileSystem
 
 
 def test_dirs(fs: HdfsFileSystem):
     fs.mkdir("/testdir")
     assert fs.info("/testdir")["type"] == "directory"
 
-    try:
+    with pytest.raises(FileExistsError):
         fs.makedirs("/testdir", exist_ok=False)
-        assert False, '"/testdir" already exists, should fail'
-    except:
-        pass
 
     fs.makedirs("/testdir", exist_ok=True)
 
     fs.mkdir("/testdir/nested/dir")
     assert fs.info("/testdir/nested/dir")["type"] == "directory"
 
-    try:
+    with pytest.raises(FileExistsError):
         fs.mkdir("/testdir/nested2/dir", create_parents=False)
-        assert False, "Should fail to make dir because parent doesn't exist"
-    except:
-        pass
 
     with pytest.raises(RuntimeError):
         fs.rm("/testdir", recursive=False)