bump modeling-cmds, nuke slow world #6753
Open
+54,754
−426,038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Instrumentation Performance ReportMerging #6753 will not alter performanceComparing Summary
|
Irev-Dev
reviewed
May 8, 2025
| @@ -292,86 +292,13 @@ pub(crate) async fn do_post_extrude<'a>( | |||
| vec![] | |||
| }; | |||
|
|
|||
| // Face filtering attempt in order to resolve https://github.com/KittyCAD/modeling-app/issues/5328 | |||
There was a problem hiding this comment.
github wont't let me comment, but a few lines up is
let solid3d_info = args
.send_modeling_cmd(
exec_state.next_uuid(),
ModelingCmd::from(mcmd::Solid3dGetExtrusionFaceInfo {
edge_id: any_edge_id,
object_id: sketch.id,
}),
)
.await?;Should this be removed too @jessfraz
There was a problem hiding this comment.
if you dont need it we dont need it!
There was a problem hiding this comment.
hmm actually looks like it's used in analyze_faces might just leave it for now.
There was a problem hiding this comment.
we still need that fwiw
Signed-off-by: Jess Frazelle <github@jessfraz.com>
jessfraz
force-pushed
the
bump-modeling-cmds
branch
from
920464e to
de98026
Compare
…ace_ids or lack there of
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.