Fix deletion of unassigned standalone edge treatments #6815
+264
−216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pierremtb
approved these changes
May 9, 2025
e2e/playwright/point-click.spec.ts
Outdated
| @@ -2507,12 +2543,13 @@ fillet04 = fillet(extrude001, radius = 5, tags = [getOppositeEdge(seg02)]) | |||
| await page.keyboard.press('Delete') | |||
| await page.waitForTimeout(500) | |||
There was a problem hiding this comment.
I'd be prob better to use scene.settled(cmdBar) here than a timeout but not a bit deal
There was a problem hiding this comment.
thank you, done: a2343fc
…m/KittyCAD/modeling-app into max/undeletable-unassigned-fillet
…m/KittyCAD/modeling-app into max/undeletable-unassigned-fillet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6794
Explanation:
This PR addresses a bug where standalone edge treatments
fillet(...)couldn't be deleted from the feature tree.Problem:
Previously, our code could only handle two cases of edge treatments:
Edge treatments in pipes:
const body = extrude(...) |> fillet(...)Edge treatments assigned to variables:
fillet0001 = fillet(...)Solution:
The fix identifies all three forms of edge treatment expressions by:
VariableDeclaratorandExpressionStatementnode typesdeleteTopLevelStatementby @jtrandeleteNodeInExtrudePipeby @Irev-DevThis ensures users can delete any edge treatment regardless of how it was created in the code.
delete.all.3.cases.mp4