Skip to content

Commit

Permalink
update to node 18+, electron builder update
Browse files Browse the repository at this point in the history
  • Loading branch information
BryonLewis committed Jan 23, 2025
1 parent 402f830 commit fbf4a5c
Show file tree
Hide file tree
Showing 6 changed files with 334 additions and 2,095 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
# "ref" specifies the branch to check out.
# "github.event.release.target_commitish" is a global variable and specifies the branch the release targeted
ref: ${{ github.event.release.target_commitish }}
- name: Use Node 16
- name: Use Node 18
uses: actions/setup-node@v3
with:
node-version: '16.14.2'
node-version: '18.18.0'
# Specifies the registry, this field is required!
registry-url: https://registry.npmjs.org/
- run: yarn install --frozen-lockfile
Expand Down
2 changes: 1 addition & 1 deletion client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@
"tsc-alias": "^1.2.0",
"tslib": "^2.6.2",
"typescript": "~4.3.5",
"vue-cli-plugin-electron-builder": "^2.1.1",
"vue-cli-plugin-electron-builder": "^v3.0.0-alpha.4",
"vue-cli-plugin-vuetify": "^2.4.3",
"vue-jest": "^3.0.7",
"vue-template-compiler": "^2.7.16",
Expand Down
3 changes: 2 additions & 1 deletion client/vue.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ module.exports = {
// https://github.com/nklayman/vue-cli-plugin-electron-builder/pull/1088
rendererProcessFile: 'platform/desktop/main.ts',
// https://www.electron.build/configuration/configuration
customFileProtocol: './',
builderOptions: {
appId: 'com.kitware.viame',
productName: 'DIVE-Desktop',
Expand All @@ -83,7 +84,7 @@ module.exports = {
extraMetadata: {
// https://github.com/nklayman/vue-cli-plugin-electron-builder/issues/188
// https://github.com/electron-userland/electron-builder/issues/2592
main: 'background.js',
main: 'index.js',
name: 'DIVE-Desktop'
},
linux: {
Expand Down
Loading

0 comments on commit fbf4a5c

Please sign in to comment.