Implement bulk import #1457
Merged
Implement bulk import #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BryonLewis the tests are fixed now. |
BryonLewis
requested changes
Nov 14, 2024
client/platform/desktop/frontend/components/BulkImportDialog.vue
Outdated
Show resolved
Hide resolved
client/platform/desktop/frontend/components/BulkImportDialog.vue
Outdated
Show resolved
Hide resolved
Run imports sequentially, to prevent ffprobe from failing. ffprobe seems to fail if run with sufficiently many concurrent processes.
jjnesbitt
force-pushed
the
bulk-import
branch
from
8b4bb89 to
40ac579
Compare
jjnesbitt
commented
Nov 14, 2024
| </v-card-title> | ||
| </v-card> | ||
| </v-dialog> | ||
| <v-dialog |
There was a problem hiding this comment.
@BryonLewis I split the current dialog into two separate dialogs, one for import / bulk data import, and the other for import status and the multicam dialog. I tested it locally and believe it works as expected, but I'm not too familiar with multicam stuff.
BryonLewis
reviewed
Nov 15, 2024
| :headers="headers" | ||
| show-select | ||
| disable-sort | ||
| @input="updateSelected" |
There was a problem hiding this comment.
Believe you still need to set some sort of max width on the data table:
DIVE-Bulk-Issue.mp4
There was a problem hiding this comment.
A specific max-width style wasn't necessary with the fix I implemented, but it still prevents overflow on all screen sizes (wraps text instead).
BryonLewis
requested changes
Nov 15, 2024
BryonLewis
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1455
Allows for bulk importing of datasets with a new "Bulk Import" button. This is done by recursively searching for datasets, wrapping the existing import sequence. If a directory fails the import sequence, the function will recurse into that directory.