zcl: update ubisys hvacThermostat custom attributes #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he hvacThermostat As of firmware 1.5.0 there is no conflict anymore, these are based on draft technical reference ubisys has send me. I noticed the manuSpecificUbisysHeatingRegulatorThermostat which was causing conflict before was also just the generic hvacThermostat cluster with the manufacturerCode set. These halve all been folded into hvacThermostat to be consistent with others like danfoss.
…e conflict free now
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Dec 22, 2023
Give manuSpecificUbisysHeatingRegulatorLevelCtrl the same treatment, there are no device with converters with these custom attributes at the moment.
|
I also noticed some of the attribute ID's were off by 1 (as per https://www.ubisys.de/wp-content/uploads/ubisys-h10-technical-reference.pdf, page 30) Also this PR should adress the other issues mentioned here #712 (comment), the Ubisys S1, S2, C4, D1 now also work correctly again. |
|
Thanks! |
This was referenced Dec 23, 2023
slugzero
pushed a commit
to slugzero/zigbee-herdsman
that referenced
this pull request
Dec 31, 2023
…enkk#835) * ubisys: move all ubisys hvacThermostat manufacture attributes under the hvacThermostat As of firmware 1.5.0 there is no conflict anymore, these are based on draft technical reference ubisys has send me. I noticed the manuSpecificUbisysHeatingRegulatorThermostat which was causing conflict before was also just the generic hvacThermostat cluster with the manufacturerCode set. These halve all been folded into hvacThermostat to be consistent with others like danfoss. * tests: manuSpecificUbisysHeatingRegulatorThermostat is no more, we are conflict free now * ubisys: move manuSpecificUbisysHeatingRegulatorLevelCtrl to levelCtrl Give manuSpecificUbisysHeatingRegulatorLevelCtrl the same treatment, there are no device with converters with these custom attributes at the moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am unable to find any references to manuSpecificUbisysHeatingRegulatorThermostat in zhc at the moment, I will do a PR to fix the Ubisys H1 that needs to be merged after this.
I did verify the attribute exist in the H10 technical reference though, so I'd like to keep them around at least if someone does do more work on the H10.
This also solves our attribute collision issue for now, as ubisys moved them to avoid a collision after feedback I provided.