chore(tracing): log instead of throwing error #14294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module could throw errors if certain validations fail. While this is useful for type validation, it can be risky when the error logic depends on more complex conditions. This commit removes the error thrown when a span's end time is earlier than its start time. Although this shouldn't happen under normal circumstances, the end time calculation depends on multiple factors, including values from Nginx, making it not trivial to ensure it is always valid. In such cases, logging an error is more appropriate than failing the request.
github-actions
bot
added
core/pdk
core/tracing
cherry-pick kong-ee
gruceo
approved these changes
Feb 19, 2025
brentos
approved these changes
Feb 19, 2025
samugi
added
cherry-pick kong-ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This module could throw errors if certain validations fail. While this is useful for type validation, it can be risky when the error logic depends on more complex conditions.
This commit removes the error thrown when a span's end time is earlier than its start time. Although this shouldn't happen under normal circumstances, the end time calculation depends on multiple factors, including values from Nginx, making it not trivial to ensure it is always valid. In such cases, logging an error is more appropriate than failing the request.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
KAG-6424